Bug 182198 – Make accessibility/mac/selection-notification-focus-change.html more reliable and re-enable it

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Ryosuke Niwa]

Right now, accessibility/mac/selection-notification-focus-change.html is marked as pass & fail.

This is because the test used to flakily fail. It now fails with the same output each time.

We should update the test to be more reliable and re-enable it everywhere.

[Radar WebKit Bug Importer]

<rdar://problem/36930258>

[Ryosuke Niwa]

Created attachment 332438 [details]
Fixes the test

[chris fleizach]

Comment on attachment 332438 [details]
Fixes the test

View in context: https://bugs.webkit.org/attachment.cgi?id=332438&action=review

> LayoutTests/accessibility/mac/selection-notification-focus-change-expected.txt:21
> +FAIL userInfo["AXTextSelectionChangedFocus"] should be true (of type boolean). Was undefined (of type undefined).

is this expected to check in the FAIL case?

[Ryosuke Niwa]

(In reply to chris fleizach from comment #3)
> Comment on attachment 332438 [details]
> Fixes the test
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332438&action=review
> 
> > LayoutTests/accessibility/mac/selection-notification-focus-change-expected.txt:21
> > +FAIL userInfo["AXTextSelectionChangedFocus"] should be true (of type boolean). Was undefined (of type undefined).
> 
> is this expected to check in the FAIL case?

No, but I have a fix coming up soon :). I wanted to land the test change first so that it's easy to see what code change fixes which test case instead of changing the code & the test at the same time.

[Ryosuke Niwa]

Committed r227713: <https://trac.webkit.org/changeset/227713>