Bug 182184 - Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky
Summary: Layout Test http/wpt/beacon/beacon-async-error-logging.html is flaky
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2018-01-26 13:11 PST by Matt Lewis
Modified: 2018-01-26 20:26 PST (History)
8 users (show)

See Also:

WIP Patch (767 bytes, patch)
2018-01-26 16:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2018-01-26 19:01 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2018-01-26 19:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2018-01-26 13:11:46 PST
The following layout test is flaky on WK2


Probable cause:

This doesn't currently have a clear regression point.

Flakiness Dashboard:




--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/wpt/beacon/beacon-async-error-logging-actual.txt
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: Beacon API cannot load http://invalid.localhost/. A server with the specified hostname could not be found.
 PASS Should log an error message in the console
Comment 1 Radar WebKit Bug Importer 2018-01-26 16:43:43 PST
Comment 2 Chris Dumez 2018-01-26 16:46:05 PST
Don't worry about the regression point. The test currently relies on a setTimeout. I'll fix.
Comment 3 Chris Dumez 2018-01-26 16:49:26 PST
Created attachment 332430 [details]
WIP Patch
Comment 4 Chris Dumez 2018-01-26 19:01:32 PST
Created attachment 332449 [details]
Comment 5 youenn fablet 2018-01-26 19:44:34 PST
Comment on attachment 332449 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=332449&action=review

> LayoutTests/http/wpt/beacon/beacon-async-error-logging.html:10
> +        internals.setConsoleMessageListener(function() {

Can we make it sort of working on regular environment by testing for window.internals and adding a text message stating to look for console message?
Comment 6 Chris Dumez 2018-01-26 19:49:55 PST
Created attachment 332451 [details]
Comment 7 WebKit Commit Bot 2018-01-26 20:26:15 PST
Comment on attachment 332451 [details]

Clearing flags on attachment: 332451

Committed r227712: <https://trac.webkit.org/changeset/227712>
Comment 8 WebKit Commit Bot 2018-01-26 20:26:17 PST
All reviewed patches have been landed.  Closing bug.