RESOLVED FIXED 182180
We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects. 
https://bugs.webkit.org/show_bug.cgi?id=182180
Summary We should only append ParserArenaDeletable pointers to ParserArena::m_deletab...
Mark Lam
Reported 2018-01-26 12:16:16 PST
<rdar://problem/36460697>
Attachments
proposed patch. (11.74 KB, patch)
2018-01-26 12:25 PST, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-01-26 12:25:22 PST
Created attachment 332401 [details] proposed patch.
Michael Saboff
Comment 2 2018-01-26 12:56:25 PST
Comment on attachment 332401 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=332401&action=review r=me > Source/JavaScriptCore/parser/Nodes.h:1698 > + // ScopeNode is never instantiate. The life-cycle of its derived classes are Change this to ScopeNode is never *directly instantiated*.
Mark Lam
Comment 3 2018-01-26 13:15:06 PST
Thanks for the review. Landed in r227692: <http://trac.webkit.org/r227692>.
Note You need to log in before you can comment on or make changes to this bug.