Bug 182180 - We should only append ParserArenaDeletable pointers to ParserArena::m_deletableObjects.
Summary: We should only append ParserArenaDeletable pointers to ParserArena::m_deletab...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2018-01-26 12:16 PST by Mark Lam
Modified: 2018-01-26 13:15 PST (History)
7 users (show)

See Also:

proposed patch. (11.74 KB, patch)
2018-01-26 12:25 PST, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-01-26 12:16:16 PST
Comment 1 Mark Lam 2018-01-26 12:25:22 PST
Created attachment 332401 [details]
proposed patch.
Comment 2 Michael Saboff 2018-01-26 12:56:25 PST
Comment on attachment 332401 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=332401&action=review


> Source/JavaScriptCore/parser/Nodes.h:1698
> +        // ScopeNode is never instantiate. The life-cycle of its derived classes are

Change this to ScopeNode is never *directly instantiated*.
Comment 3 Mark Lam 2018-01-26 13:15:06 PST
Thanks for the review.  Landed in r227692: <http://trac.webkit.org/r227692>.