Bug 182175 – Disable TLS-based TLCs

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Radar WebKit Bug Importer]

<rdar://problem/36914694>

[Filip Pizlo]

Created attachment 332384 [details]
the patch

[EWS Watchlist]

Attachment 332384 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Platform.h:826:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:827:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:828:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
Total errors found: 3 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 332384 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332384&action=review

r=me

> Source/JavaScriptCore/heap/BlockDirectory.cpp:51
> +BlockDirectory::~BlockDirectory()
> +{
> +}
> +

Is this necessary since it's the default implementation?

> Source/JavaScriptCore/heap/BlockDirectory.h:83
> +    ~BlockDirectory();

Is this necessary?

[Mark Lam]

Comment on attachment 332384 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332384&action=review

> Source/WTF/wtf/Platform.h:828
> +// This feature is currently disabled because WebCore will context switch VMs without telling JSC.
> +// FIXME: Re-enable this feature.
> +// https://bugs.webkit.org/show_bug.cgi?id=182173

Please convert these to C comments.  As style bot indicated, C++ comments not allowed in this file.

[Filip Pizlo]

(In reply to Mark Lam from comment #4)
> Comment on attachment 332384 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332384&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/heap/BlockDirectory.cpp:51
> > +BlockDirectory::~BlockDirectory()
> > +{
> > +}
> > +
> 
> Is this necessary since it's the default implementation?
> 
> > Source/JavaScriptCore/heap/BlockDirectory.h:83
> > +    ~BlockDirectory();
> 
> Is this necessary?

It's often useful to put debugging print statements in the destructors of GC data structures.  So, I've been making sure that new data structures always have out-of-line destructors.  I added an out-of-line destructor while debugging, and I think it's most useful if I just land it.

[Filip Pizlo]

(In reply to Mark Lam from comment #5)
> Comment on attachment 332384 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332384&action=review
> 
> > Source/WTF/wtf/Platform.h:828
> > +// This feature is currently disabled because WebCore will context switch VMs without telling JSC.
> > +// FIXME: Re-enable this feature.
> > +// https://bugs.webkit.org/show_bug.cgi?id=182173
> 
> Please convert these to C comments.  As style bot indicated, C++ comments
> not allowed in this file.

Ooops!  Landing follow-up fix.

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/227683/webkit and https://trac.webkit.org/changeset/227684/webkit

[Filip Pizlo]

This was landed.