Bug 182169 - [iOS] prefers-reduced-motion media query is not working
Summary: [iOS] prefers-reduced-motion media query is not working
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-26 05:05 PST by Antoine Quint
Modified: 2018-01-27 15:02 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2018-01-26 05:08 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-01-26 05:05:07 PST 
The demo at https://webkit.org/blog-files/prefers-reduced-motion/prm.htm is not working.
Comment 1 Antoine Quint 2018-01-26 05:05:24 PST 
<rdar://problem/36801631>
Comment 2 Antoine Quint 2018-01-26 05:08:13 PST 
Created attachment 332366 [details]
Patch
Comment 3 chris fleizach 2018-01-26 08:09:15 PST 
Comment on attachment 332366 [details]
Patch

Is there a reason this is tied to the new theme flag? I would expect it to work unconditionally on all platforms
Comment 4 WebKit Commit Bot 2018-01-26 11:39:41 PST 
Comment on attachment 332366 [details]
Patch

Clearing flags on attachment: 332366

Committed r227686: <https://trac.webkit.org/changeset/227686>
Comment 5 WebKit Commit Bot 2018-01-26 11:39:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Dean Jackson 2018-01-26 17:56:04 PST 
(In reply to chris fleizach from comment #3)
> Comment on attachment 332366 [details]
> Patch
> 
> Is there a reason this is tied to the new theme flag? I would expect it to
> work unconditionally on all platforms

I don't know what I was thinking in my original patch, surrounding that with NEW_THEME. That also must have applied to iOS at the time.

Here's a patch to remove it: https://bugs.webkit.org/show_bug.cgi?id=182203

We'll see if it compiles everywhere :)
Comment 7 James Craig 2018-01-27 15:02:01 PST 
<rdar://problem/36801631>