Bug 182167 - WebDriver: timeouts value and cookie expiry should be limited to max safe integer
Summary: WebDriver: timeouts value and cookie expiry should be limited to max safe int...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-26 01:37 PST by Carlos Garcia Campos
Modified: 2018-01-26 01:52 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.24 KB, patch)
2018-01-26 01:44 PST, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-26 01:37:29 PST 
This changed recently in the spec:

https://github.com/w3c/webdriver/pull/1210

Our implementation was wrong in any case since we are limiting to INT_MAX.
Comment 1 Carlos Garcia Campos 2018-01-26 01:44:34 PST 
Created attachment 332360 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-01-26 01:51:06 PST 
Committed r227671: <https://trac.webkit.org/changeset/227671>
Comment 3 Radar WebKit Bug Importer 2018-01-26 01:52:29 PST 
<rdar://problem/36903286>