Bug 182162 - Web Inspector: "Displayed Columns" should not be displayed in context menu if all columns are required columns
Summary: Web Inspector: "Displayed Columns" should not be displayed in context menu if...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 20:09 PST by Joseph Pecoraro
Modified: 2018-01-25 20:58 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.99 KB, patch)
2018-01-25 20:14 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-25 20:09:59 PST 
"Displayed Columns" should not be displayed in context menu if all columns are required columns

* Steps to reproduce
1. Inspect <http://webkit.org>
2. Show Network Tab
3. Select a resource with cookie data (reload if needed)
4. Select the Cookie tab
5. Right-click the column header for Request Cookies
  => Context menu should not have "Displayed Columns" header since no columns can be toggled
Comment 1 Joseph Pecoraro 2018-01-25 20:10:10 PST 
<rdar://problem/36893758>
Comment 2 Joseph Pecoraro 2018-01-25 20:14:26 PST 
Created attachment 332347 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2018-01-25 20:35:12 PST 
Comment on attachment 332347 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2018-01-25 20:58:38 PST 
Comment on attachment 332347 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 332347

Committed r227652: <https://trac.webkit.org/changeset/227652>
Comment 5 WebKit Commit Bot 2018-01-25 20:58:39 PST 
All reviewed patches have been landed.  Closing bug.