Bug 182152 – REGRESSION (r221899): Web Content process hangs when webpage tries to make a new window if the WKWebView doesn’t have a UI delegate

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

rdar://problem/36881934

If the webpage tries to create a new window, and the WKWebView doesn’t have a UI delegate, the Web Content process will hang.

This was introduced in <https://trac.webkit.org/r221899> (the change made for bug 176568). It made the base implementation of API::UIClient::createNewPage() just return, instead of calling the completion handler with a null pointer. This leaves the Web Content process blocked waiting indefinitely.

[Alex Christensen]

Created attachment 332335 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 332335 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332335&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:100
> +    TestWebKitAPI::Util::run(&done);

While it might not matter right now, I think you should be setting `done = false` in here so this Util::run really waits for your done condition and not an earlier test's done condition.

[Alex Christensen]

trac.webkit.org/r227647

[Carlos Garcia Campos]

Fixed GTK/WPE in r227670: <https://trac.webkit.org/changeset/227670>