Bug 182134 – ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

ServiceWorkerClientFetch should not consider responses without Location headers as redirection responses

[youenn fablet]

Created attachment 332296 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/36878770>

[Chris Dumez]

Comment on attachment 332296 [details]
Patch

r=me

[EWS Watchlist]

Comment on attachment 332296 [details]
Patch

Attachment 332296 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6211908

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

[EWS Watchlist]

Created attachment 332304 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 332296 [details]
Patch

Attachment 332296 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6212000

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect.https.html

[EWS Watchlist]

Created attachment 332309 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 332432 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 332432 [details]
Patch

Clearing flags on attachment: 332432

Committed r227770: <https://trac.webkit.org/changeset/227770>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Matt Lewis]

This is failing on macOS with the occasional crash and is crashing on iOS simulator Debug and failing on iOS Release fairly consistently.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fnavigation-redirect.https.html

https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r227790%20(2861)/results.html
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/builds/2861

[Matt Lewis]

It looks like the crash this test is hitting is the same in: https://bugs.webkit.org/show_bug.cgi?id=182054

[youenn fablet]

(In reply to Matt Lewis from comment #12)
> It looks like the crash this test is hitting is the same in:
> https://bugs.webkit.org/show_bug.cgi?id=182054

That makes sense.
Before the patch, the patch was skipped.
With the patch, the test runs successfully and uses message ports internally to help testing.