Bug 182131 - [webkitpy] Config file for apache is copied twice.
Summary: [webkitpy] Config file for apache is copied twice.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 12:06 PST by Basuke Suzuki
Modified: 2018-01-31 10:06 PST (History)
12 users (show)

See Also:

Attachments
fix (2.62 KB, patch)
2018-01-25 12:16 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-01-25 12:06:50 PST 
Config file is copied in _get_apache_config_file_path(), but it is called twice.
Comment 1 Basuke Suzuki 2018-01-25 12:16:49 PST 
Created attachment 332297 [details]
fix
Comment 2 Daniel Bates 2018-01-30 20:14:37 PST 
Comment on attachment 332297 [details]
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=332297&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:95
> +            '-f', "\"%s\"" % config_file_path,

It would be good to understand why we need to copy the config file to begin with. This is unrelated to your patch.
Comment 3 WebKit Commit Bot 2018-01-30 20:27:46 PST 
Comment on attachment 332297 [details]
fix

Clearing flags on attachment: 332297

Committed r227871: <https://trac.webkit.org/changeset/227871>
Comment 4 WebKit Commit Bot 2018-01-30 20:27:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-30 20:28:21 PST 
<rdar://problem/37054960>
Comment 6 Basuke Suzuki 2018-01-31 10:06:29 PST 
> It would be good to understand why we need to copy the config file to begin
> with. This is unrelated to your patch.

Agreed. Who has the context of this? My guess is that somebody had tried to modify config file to configure, but later passing them by arguments was okay and accepted. Then coping just left as is.