Bug 182116 - Make sure we have a frame as we iterate in ResourceLoadObserver::nonNullOwnerURL()
Summary: Make sure we have a frame as we iterate in ResourceLoadObserver::nonNullOwner...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 11:34 PST by John Wilander
Modified: 2018-01-25 14:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2018-01-25 11:39 PST, John Wilander 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2018-01-25 11:34:20 PST 
We need to check that we have a frame before using it as we traverse the frame hierarchy up to find a non-null URL in ResourceLoadObserver::nonNullOwnerURL().
Comment 1 John Wilander 2018-01-25 11:34:40 PST 
rdar://problem/36210134
Comment 2 John Wilander 2018-01-25 11:39:11 PST 
Created attachment 332294 [details]
Patch
Comment 3 John Wilander 2018-01-25 11:46:04 PST 
In the case where we don't have a frame, the returned URL is empty which through the call to ResourceLoadStatistics::primaryDomain() becomes "nullOrigin".
Comment 4 John Wilander 2018-01-25 14:31:21 PST 
Committed r227632: <https://trac.webkit.org/changeset/227632>
Comment 5 John Wilander 2018-01-25 14:31:36 PST 
Thanks, Alex!