Bug 182114 - Fix crash when preconnecting while closing private browsing
Summary: Fix crash when preconnecting while closing private browsing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 11:16 PST by Alex Christensen
Modified: 2018-01-25 12:14 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.70 KB, patch)
2018-01-25 11:18 PST, Alex Christensen 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-25 11:16:36 PST 
Fix crash when preconnecting while closing private browsing
Comment 1 Alex Christensen 2018-01-25 11:18:31 PST 
Created attachment 332288 [details]
Patch
Comment 2 Joseph Pecoraro 2018-01-25 11:47:46 PST 
Comment on attachment 332288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332288&action=review

r=me

> Source/WebKit/NetworkProcess/PreconnectTask.cpp:50
>      ASSERT(networkSession);

We should probably remove this assert. Or make a better assert inside of the block, since it sounds like we have a series of events where we know this can happen.
Comment 3 Alex Christensen 2018-01-25 12:13:53 PST 
trac.webkit.org/r227621
Comment 4 Radar WebKit Bug Importer 2018-01-25 12:14:22 PST 
<rdar://problem/36877885>