Bug 182102 - [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
Summary: [WebVR][GTK][WPE] Remove the WebVR public API added in r227518
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 07:39 PST by Sergio Villar Senin
Modified: 2018-01-25 09:59 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.11 KB, patch)
2018-01-25 07:40 PST, Sergio Villar Senin
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2018-01-25 07:39:40 PST
[WebVR][GTK][WPE] Remove the WebVR public API added in r227518
Comment 1 Sergio Villar Senin 2018-01-25 07:40:25 PST
Created attachment 332265 [details]
Patch
Comment 2 EWS Watchlist 2018-01-25 07:41:20 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2018-01-25 07:45:02 PST
Comment on attachment 332265 [details]
Patch

Remember the changes in MB too. Thanks!
Comment 4 Sergio Villar Senin 2018-01-25 07:47:51 PST
Right I forgot to remove that too. Thanks for the quick review
Comment 5 Sergio Villar Senin 2018-01-25 07:52:12 PST
I also removed the new API from the docs
Comment 6 Sergio Villar Senin 2018-01-25 07:52:27 PST
Committed r227607: <https://trac.webkit.org/changeset/227607>
Comment 7 Radar WebKit Bug Importer 2018-01-25 07:53:15 PST
<rdar://problem/36868357>
Comment 8 Michael Catanzaro 2018-01-25 09:59:23 PST
Careful with prepare-ChangeLog! It's annoying; I usually double-check it before landing, and still forget sometimes....