Bug 182094 - [Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
Summary: [Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 02:44 PST by Zan Dobersek
Modified: 2018-01-25 04:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2018-01-25 02:52 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (2.23 KB, patch)
2018-01-25 03:46 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-01-25 02:44:38 PST
[Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
Comment 1 Zan Dobersek 2018-01-25 02:52:20 PST
Created attachment 332245 [details]
Patch
Comment 2 EWS Watchlist 2018-01-25 02:55:10 PST
Attachment 332245 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:73:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Carlos Garcia Campos 2018-01-25 02:56:47 PST
Comment on attachment 332245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332245&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:76
> +    m_graphicsContext = std::make_unique<WebCore::GraphicsContext>(
> +            [this](WebCore::GraphicsContext& context)
> +            {
> +                return std::make_unique<WebCore::GraphicsContextImplCairo>(context, *m_platformContext);
> +            });

Fix the indentation here.
Comment 4 Zan Dobersek 2018-01-25 03:46:39 PST
Created attachment 332252 [details]
Patch for landing
Comment 5 Zan Dobersek 2018-01-25 04:18:39 PST
Comment on attachment 332252 [details]
Patch for landing

Clearing flags on attachment: 332252

Committed r227599: <https://trac.webkit.org/changeset/227599>
Comment 6 Zan Dobersek 2018-01-25 04:18:43 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-25 04:20:32 PST
<rdar://problem/36862641>