WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182094
[Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
https://bugs.webkit.org/show_bug.cgi?id=182094
Summary
[Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
Zan Dobersek
Reported
2018-01-25 02:44:38 PST
[Cairo] Use GraphicsContextImplCairo in Nicosia::PaintingContextCairo
Attachments
Patch
(2.35 KB, patch)
2018-01-25 02:52 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Patch for landing
(2.23 KB, patch)
2018-01-25 03:46 PST
,
Zan Dobersek
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Zan Dobersek
Comment 1
2018-01-25 02:52:20 PST
Created
attachment 332245
[details]
Patch
EWS Watchlist
Comment 2
2018-01-25 02:55:10 PST
Attachment 332245
[details]
did not pass style-queue: ERROR: Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:73: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] WARNING: This machine could support 4 simulators, but is only configured for 3. WARNING: Please see <
https://trac.webkit.org/wiki/IncreasingKernelLimits
>. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3
2018-01-25 02:56:47 PST
Comment on
attachment 332245
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=332245&action=review
> Source/WebCore/platform/graphics/nicosia/NicosiaPaintingContextCairo.cpp:76 > + m_graphicsContext = std::make_unique<WebCore::GraphicsContext>( > + [this](WebCore::GraphicsContext& context) > + { > + return std::make_unique<WebCore::GraphicsContextImplCairo>(context, *m_platformContext); > + });
Fix the indentation here.
Zan Dobersek
Comment 4
2018-01-25 03:46:39 PST
Created
attachment 332252
[details]
Patch for landing
Zan Dobersek
Comment 5
2018-01-25 04:18:39 PST
Comment on
attachment 332252
[details]
Patch for landing Clearing flags on attachment: 332252 Committed
r227599
: <
https://trac.webkit.org/changeset/227599
>
Zan Dobersek
Comment 6
2018-01-25 04:18:43 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-01-25 04:20:32 PST
<
rdar://problem/36862641
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug