Bug 182091 - Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing
Summary: Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-25 01:24 PST by Jer Noble
Modified: 2018-01-25 14:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (29.04 KB, patch)
2018-01-25 01:29 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.27 MB, application/zip)
2018-01-25 02:34 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-sierra (2.92 MB, application/zip)
2018-01-25 03:55 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.95 MB, application/zip)
2018-01-25 05:02 PST, EWS Watchlist
no flags Details
Patch (30.08 KB, patch)
2018-01-25 08:34 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.14 MB, application/zip)
2018-01-25 10:17 PST, EWS Watchlist
no flags Details
Patch (29.87 KB, patch)
2018-01-25 10:29 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (40.13 KB, patch)
2018-01-25 10:32 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-01-25 01:24:11 PST
Move ImageDecoderAVFObjC from using AVSampleBufferGenerator to AVAssetReaderOutput for parsing
Comment 1 Jer Noble 2018-01-25 01:29:08 PST
Created attachment 332239 [details]
Patch
Comment 2 EWS Watchlist 2018-01-25 01:30:00 PST Comment hidden (obsolete)
Comment 3 EWS Watchlist 2018-01-25 02:34:18 PST Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-01-25 02:34:19 PST Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-01-25 03:55:56 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-01-25 03:55:57 PST Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-01-25 05:02:36 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-01-25 05:02:37 PST Comment hidden (obsolete)
Comment 9 Jer Noble 2018-01-25 08:34:33 PST
Created attachment 332271 [details]
Patch
Comment 10 EWS Watchlist 2018-01-25 08:36:07 PST Comment hidden (obsolete)
Comment 11 EWS Watchlist 2018-01-25 10:17:08 PST Comment hidden (obsolete)
Comment 12 EWS Watchlist 2018-01-25 10:17:09 PST Comment hidden (obsolete)
Comment 13 Jer Noble 2018-01-25 10:29:28 PST
Created attachment 332280 [details]
Patch
Comment 14 EWS Watchlist 2018-01-25 10:31:09 PST Comment hidden (obsolete)
Comment 15 Jer Noble 2018-01-25 10:32:42 PST
Created attachment 332282 [details]
Patch
Comment 16 EWS Watchlist 2018-01-25 10:34:20 PST
Attachment 332282 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:46:  value_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/Modules/mediasource/SampleMap.h:81:  value_type is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Jer Noble 2018-01-25 14:17:52 PST
<rdar://problem/36882492>
Comment 18 WebKit Commit Bot 2018-01-25 14:30:00 PST
Comment on attachment 332282 [details]
Patch

Clearing flags on attachment: 332282

Committed r227631: <https://trac.webkit.org/changeset/227631>
Comment 19 WebKit Commit Bot 2018-01-25 14:30:01 PST
All reviewed patches have been landed.  Closing bug.