Bug 182082 - ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::setFrameAndScrollBy()
Summary: ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-24 19:10 PST by Simon Fraser (smfr)
Modified: 2018-01-31 08:53 PST (History)
10 users (show)

See Also:

Attachments
Patch (15.73 KB, patch)
2018-01-24 19:13 PST, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (17.71 KB, patch)
2018-01-25 09:46 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-01-24 19:10:57 PST 
ASSERT(CGSizeEqualToSize(m_resizeScrollOffset, CGSizeZero)) in WebViewImpl::setFrameAndScrollBy()
Comment 1 Simon Fraser (smfr) 2018-01-24 19:13:46 PST 
Created attachment 332219 [details]
Patch
Comment 2 Tim Horton 2018-01-24 19:44:59 PST 
Comment on attachment 332219 [details]
Patch

I think you’ll (probably) want to fix the other ports builds. Though it does seem like AcceleratedDrawingAreaProxy might use m_scrollOffset...
Comment 3 Simon Fraser (smfr) 2018-01-25 09:46:01 PST 
Created attachment 332275 [details]
Patch
Comment 4 EWS Watchlist 2018-01-25 09:48:17 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 WebKit Commit Bot 2018-01-25 14:27:32 PST 
Comment on attachment 332275 [details]
Patch

Clearing flags on attachment: 332275

Committed r227630: <https://trac.webkit.org/changeset/227630>
Comment 6 Eric Carlson 2018-01-26 07:20:58 PST 
Comment on attachment 332275 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332275&action=review

> Source/WebKit/ChangeLog:12
> +        Rename to m_resizeScrollOffset to m_scrollOffsetAdjustment to reduce confusion with actual scroll offsets.

Nit: Too many tos in  "Rename to ... to ... to ..."
Comment 7 Radar WebKit Bug Importer 2018-01-31 08:53:25 PST 
<rdar://problem/37072206>