Bug 182067 – Web Inspector: Simplify update-LegacyInspectorBackendCommands.rb

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Simplify update-LegacyInspectorBackendCommands.rb

- It doesn't need to generate the InspectorBackendDispatcher/InspectorFrontendDispatcher
- The dependency_json is no longer needed and always empty

[Joseph Pecoraro]

Created attachment 332202 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 332203 [details]
[PATCH] Proposed Fix

[EWS Watchlist]

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[EWS Watchlist]

Attachment 332203 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:199:  [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator'  [pylint/E0602] [5]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Blaze Burg]

Comment on attachment 332203 [details]
[PATCH] Proposed Fix

r=me but let's file a bug against EWS

[Blaze Burg]

(In reply to Build Bot from comment #4)
> Attachment 332203 [details] did not pass style-queue:
> 
> 
> ERROR:
> Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
> py:199:  [generate_from_specification] Undefined variable
> 'JSBackendCommandsGenerator'  [pylint/E0602] [5]

This is frivolous, pylint can't see into the glob import that imports this symbol.

> WARNING: This machine could support 4 simulators, but is only configured for
> 3.
> WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> Total errors found: 1 in 5 files

Um, that's strange.

[Aakash Jain]

> > WARNING: This machine could support 4 simulators, but is only configured for 3.
> > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> 
> Um, that's strange.

https://bugs.webkit.org/show_bug.cgi?id=181702 should fix this.

[Joseph Pecoraro]

> > ERROR:
> > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
> > py:199:  [generate_from_specification] Undefined variable
> > 'JSBackendCommandsGenerator'  [pylint/E0602] [5]
> 
> This is frivolous, pylint can't see into the glob import that imports this symbol.

<https://webkit.org/b/182071> check-webkit-style: False positive python undefined variable pylon warning - linter doesn't seem to follow includes


> > WARNING: This machine could support 4 simulators, but is only configured for 3.
> > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> > Total errors found: 1 in 5 files
> 
> Um, that's strange.

<https://webkit.org/b/181702> webkit-patch upload emits irrelevant simulator warnings

[WebKit Commit Bot]

Comment on attachment 332203 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 332203

Committed r227586: <https://trac.webkit.org/changeset/227586>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.