Bug 182067 - Web Inspector: Simplify update-LegacyInspectorBackendCommands.rb
Summary: Web Inspector: Simplify update-LegacyInspectorBackendCommands.rb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2018-01-24 15:00 PST by Joseph Pecoraro
Modified: 2018-01-24 16:22 PST (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (5.33 KB, patch)
2018-01-24 15:02 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (5.16 KB, patch)
2018-01-24 15:03 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-24 15:00:02 PST
Simplify update-LegacyInspectorBackendCommands.rb

- It doesn't need to generate the InspectorBackendDispatcher/InspectorFrontendDispatcher
- The dependency_json is no longer needed and always empty
Comment 1 Joseph Pecoraro 2018-01-24 15:02:21 PST
Created attachment 332202 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2018-01-24 15:03:20 PST
Created attachment 332203 [details]
[PATCH] Proposed Fix
Comment 3 EWS Watchlist 2018-01-24 15:06:21 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 EWS Watchlist 2018-01-24 15:06:33 PST
Attachment 332203 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.py:199:  [generate_from_specification] Undefined variable 'JSBackendCommandsGenerator'  [pylint/E0602] [5]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 BJ Burg 2018-01-24 15:17:38 PST
Comment on attachment 332203 [details]
[PATCH] Proposed Fix

r=me but let's file a bug against EWS
Comment 6 BJ Burg 2018-01-24 15:18:34 PST
(In reply to Build Bot from comment #4)
> Attachment 332203 [details] did not pass style-queue:
> 
> 
> ERROR:
> Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
> py:199:  [generate_from_specification] Undefined variable
> 'JSBackendCommandsGenerator'  [pylint/E0602] [5]

This is frivolous, pylint can't see into the glob import that imports this symbol.

> WARNING: This machine could support 4 simulators, but is only configured for
> 3.
> WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> Total errors found: 1 in 5 files

Um, that's strange.
Comment 7 Aakash Jain 2018-01-24 16:03:42 PST
> > WARNING: This machine could support 4 simulators, but is only configured for 3.
> > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> 
> Um, that's strange.

https://bugs.webkit.org/show_bug.cgi?id=181702 should fix this.
Comment 8 Joseph Pecoraro 2018-01-24 16:06:21 PST
> > ERROR:
> > Source/JavaScriptCore/inspector/scripts/generate-inspector-protocol-bindings.
> > py:199:  [generate_from_specification] Undefined variable
> > 'JSBackendCommandsGenerator'  [pylint/E0602] [5]
> 
> This is frivolous, pylint can't see into the glob import that imports this symbol.

<https://webkit.org/b/182071> check-webkit-style: False positive python undefined variable pylon warning - linter doesn't seem to follow includes


> > WARNING: This machine could support 4 simulators, but is only configured for 3.
> > WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
> > Total errors found: 1 in 5 files
> 
> Um, that's strange.

<https://webkit.org/b/181702> webkit-patch upload emits irrelevant simulator warnings
Comment 9 WebKit Commit Bot 2018-01-24 16:22:33 PST
Comment on attachment 332203 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 332203

Committed r227586: <https://trac.webkit.org/changeset/227586>
Comment 10 WebKit Commit Bot 2018-01-24 16:22:34 PST
All reviewed patches have been landed.  Closing bug.