Bug 182063 - [Curl] Implement didSendData client callback.
Summary: [Curl] Implement didSendData client callback.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-24 14:18 PST by Basuke Suzuki
Modified: 2018-01-24 20:14 PST (History)
7 users (show)

See Also:


Attachments
Patch (4.35 KB, patch)
2018-01-24 14:21 PST, Basuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-01-24 14:18:08 PST
Curl port didn't have this implementation. Now we have.
Comment 1 Basuke Suzuki 2018-01-24 14:21:43 PST
Created attachment 332199 [details]
Patch
Comment 2 Alex Christensen 2018-01-24 14:28:36 PST
Comment on attachment 332199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review

> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190
> +    m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent);

You might want to check these for null.
Comment 3 Don Olmstead 2018-01-24 14:33:04 PST
Comment on attachment 332199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332199&action=review

>> Source/WebCore/platform/network/curl/ResourceHandleCurlDelegate.cpp:190
>> +    m_handle->client()->didSendData(m_handle, bytesSent, totalBytesToBeSent);
> 
> You might want to check these for null.

Looks like cancelledOrClientless does that correct Basuke?
Comment 4 Basuke Suzuki 2018-01-24 16:00:54 PST
Null check was done in callClient utility method. It is also guarded by protectThis.
Comment 5 Basuke Suzuki 2018-01-24 16:01:55 PST
Oh, I misunderstood the point. I'm checking.
Comment 6 Basuke Suzuki 2018-01-24 16:04:06 PST
Don is correct. It was checked by cancelledOrClientless().
Comment 7 WebKit Commit Bot 2018-01-24 20:13:00 PST
Comment on attachment 332199 [details]
Patch

Clearing flags on attachment: 332199

Committed r227591: <https://trac.webkit.org/changeset/227591>
Comment 8 WebKit Commit Bot 2018-01-24 20:13:01 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-01-24 20:14:06 PST
<rdar://problem/36853125>