Bug 182055 - Fix race-condition in fast/text/click-ellipsis-assertion-failure.html
Summary: Fix race-condition in fast/text/click-ellipsis-assertion-failure.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-24 11:17 PST by Jonathan Bedard
Modified: 2018-01-24 14:29 PST (History)
8 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2018-01-24 11:19 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-01-24 11:17:16 PST
fast/text/click-ellipsis-assertion-failure.html should wait for it's promise to be fulfilled before finishing the test. If it does not, the subsequent test may crash.
Comment 1 Jonathan Bedard 2018-01-24 11:17:40 PST
<rdar://problem/36830203>
Comment 2 Jonathan Bedard 2018-01-24 11:19:46 PST
Created attachment 332181 [details]
Patch
Comment 3 Jonathan Bedard 2018-01-24 11:23:01 PST
I very much doubt that this is the only test suffering from this problem.  However, I think we should take these one-at-a-time. This specific bug will look like a flakey crash occurring on the test immediately after the test with the bug. Thankfully, the crashlog of the subsequent test will specifically call out the test with the race condition.
Comment 4 Megan Gardner 2018-01-24 13:57:36 PST
Can we make sure to file a bug about the other tests? There's been a lot more async code in our tests in the last few months, while it makes the tests more readable, I think it will make these races a lot more common, and we should try and keep a handle on it.
Comment 5 Jonathan Bedard 2018-01-24 14:07:55 PST
(In reply to Megan Gardner from comment #4)
> Can we make sure to file a bug about the other tests? There's been a lot
> more async code in our tests in the last few months, while it makes the
> tests more readable, I think it will make these races a lot more common, and
> we should try and keep a handle on it.

I've filed <https://bugs.webkit.org/show_bug.cgi?id=182062>.

Ryan and I are working on repaying technical debt in iOS layout tests, this is one class of failures we will be looking for.
Comment 6 WebKit Commit Bot 2018-01-24 14:25:08 PST
Comment on attachment 332181 [details]
Patch

Clearing flags on attachment: 332181

Committed r227571: <https://trac.webkit.org/changeset/227571>
Comment 7 WebKit Commit Bot 2018-01-24 14:25:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-01-24 14:29:08 PST
<rdar://problem/36839587>