Bug 182031 - [GTK] Use GDK_EVENT_PROPAGATE and GDK_EVENT_STOP in WebKitWebViewBase.cpp
Summary: [GTK] Use GDK_EVENT_PROPAGATE and GDK_EVENT_STOP in WebKitWebViewBase.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-23 17:56 PST by Michael Catanzaro
Modified: 2018-01-24 07:25 PST (History)
7 users (show)

See Also:


Attachments
Patch (7.60 KB, patch)
2018-01-23 18:01 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-01-23 17:56:38 PST
GDK_EVENT_PROPAGATE and GDK_EVENT_STOP were added in GTK+ 3.4, and we require GTK+ 3.6. We should use them in WebKitWebViewBase to make the event handlers a bit easier to read.
Comment 1 Michael Catanzaro 2018-01-23 18:01:05 PST
Created attachment 332111 [details]
Patch
Comment 2 Build Bot 2018-01-23 18:01:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2018-01-24 07:25:18 PST
Comment on attachment 332111 [details]
Patch

Clearing flags on attachment: 332111

Committed r227519: <https://trac.webkit.org/changeset/227519>
Comment 4 WebKit Commit Bot 2018-01-24 07:25:20 PST
All reviewed patches have been landed.  Closing bug.