Bug 182030 – Layout Test http/tests/workers/service/basic-unregister-then-register-again-reuse.html is flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Matt Lewis]

The following layout test is flaky on macOS WK2

http/tests/workers/service/basic-unregister-then-register-again-reuse.html

Probable cause:

This seems to have recently started. The change in https://trac.webkit.org/changeset/227275/webkit is related via service workers, however it doesn't seem to be a cause.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-unregister-then-register-again-reuse.html

Diff:

--- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/workers/service/basic-unregister-then-register-again-reuse-actual.txt
@@ -1,5 +1,5 @@
 PASS: registration1 should not have an installing worker
 PASS: registration1 should not have a waiting worker
 PASS: registration1 should have an active worker
-PASS: Registration was reused
+FAIL: Registration was not reused

[Radar WebKit Bug Importer]

<rdar://problem/36802933>

[Brady Eidson]

(In reply to Matt Lewis from comment #0)
> The following layout test is flaky on macOS WK2
> 
> http/tests/workers/service/basic-unregister-then-register-again-reuse.html
> 
> Probable cause:
> 
> This seems to have recently started. The change in
> https://trac.webkit.org/changeset/227275/webkit is related via service
> workers, however it doesn't seem to be a cause.

227275 is not related to SW - it was a no-behavior-change for SW>

> 
> Flakiness Dashboard:
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=http%2Ftests%2Fworkers%2Fservice%2Fbasic-
> unregister-then-register-again-reuse.html
> 
> Diff:
> 
> ---
> /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
> http/tests/workers/service/basic-unregister-then-register-again-reuse-
> expected.txt
> +++
> /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/
> http/tests/workers/service/basic-unregister-then-register-again-reuse-actual.
> txt
> @@ -1,5 +1,5 @@
>  PASS: registration1 should not have an installing worker
>  PASS: registration1 should not have a waiting worker
>  PASS: registration1 should have an active worker
> -PASS: Registration was reused
> +FAIL: Registration was not reused

[Chris Dumez]

Will try and look into this today.

[Chris Dumez]

Created attachment 332183 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 332183 [details]
Patch

Clearing flags on attachment: 332183

Committed r227557: <https://trac.webkit.org/changeset/227557>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.