RESOLVED FIXED 182026
Remove pre-Sierra-OS-specific code in WebCore 
https://bugs.webkit.org/show_bug.cgi?id=182026
Summary Remove pre-Sierra-OS-specific code in WebCore
Alex Christensen
Reported 2018-01-23 17:06:43 PST
Remove pre-Sierra-OS-specific code in WebCore
Attachments
Patch (43.52 KB, patch)
2018-01-23 17:10 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (43.36 KB, patch)
2018-01-23 17:44 PST, Alex Christensen 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-01-23 17:10:30 PST
Created attachment 332102 [details] Patch
Alex Christensen
Comment 2 2018-01-23 17:44:21 PST
Created attachment 332108 [details] Patch
Tim Horton
Comment 3 2018-01-24 10:59:55 PST
Comment on attachment 332108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332108&action=review > Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:-175 > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS) I think this needs to become PLATFORM(COCOA)?
Alex Christensen
Comment 4 2018-01-24 12:54:17 PST
Comment on attachment 332108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=332108&action=review >> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:-175 >> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS) > > I think this needs to become PLATFORM(COCOA)? This is inside a #if defined(__OBJC__) so I don't think that's necessary.
Tim Horton
Comment 5 2018-01-24 12:55:49 PST
Oh! I just assumed that was why windows was broken, but didn’t look.
Alex Christensen
Comment 6 2018-01-24 12:59:07 PST
trac.webkit.org/r227552
Radar WebKit Bug Importer
Comment 7 2018-01-24 13:01:00 PST
<rdar://problem/36836036>
Alex Christensen
Comment 8 2018-01-24 13:44:29 PST
trac.webkit.org/r227558
Note You need to log in before you can comment on or make changes to this bug.