Bug 182026 - Remove pre-Sierra-OS-specific code in WebCore
Summary: Remove pre-Sierra-OS-specific code in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 17:06 PST by Alex Christensen
Modified: 2018-01-24 13:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (43.52 KB, patch)
2018-01-23 17:10 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (43.36 KB, patch)
2018-01-23 17:44 PST, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-23 17:06:43 PST
Remove pre-Sierra-OS-specific code in WebCore
Comment 1 Alex Christensen 2018-01-23 17:10:30 PST
Created attachment 332102 [details]
Patch
Comment 2 Alex Christensen 2018-01-23 17:44:21 PST
Created attachment 332108 [details]
Patch
Comment 3 Tim Horton 2018-01-24 10:59:55 PST
Comment on attachment 332108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332108&action=review

> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:-175
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS)

I think this needs to become PLATFORM(COCOA)?
Comment 4 Alex Christensen 2018-01-24 12:54:17 PST
Comment on attachment 332108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332108&action=review

>> Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:-175
>> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS)
> 
> I think this needs to become PLATFORM(COCOA)?

This is inside a #if defined(__OBJC__) so I don't think that's necessary.
Comment 5 Tim Horton 2018-01-24 12:55:49 PST
Oh! I just assumed that was why windows was broken, but didn’t look.
Comment 6 Alex Christensen 2018-01-24 12:59:07 PST
trac.webkit.org/r227552
Comment 7 Radar WebKit Bug Importer 2018-01-24 13:01:00 PST
<rdar://problem/36836036>
Comment 8 Alex Christensen 2018-01-24 13:44:29 PST
trac.webkit.org/r227558