WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182015
check-webkit-style reports false-positive whitespace/braces warning about blocks with return types as arguments in Objective-C
https://bugs.webkit.org/show_bug.cgi?id=182015
Summary
check-webkit-style reports false-positive whitespace/braces warning about blo...
David Kilzer (:ddkilzer)
Reported
2018-01-23 14:44:06 PST
This code which contains a block argument with a return type: [delegate setPolicyForURL:^_WKWebsitePolicy(NSURL *url) { return _WKWebsitePolicyDoIt; }]; Triggers a false-positive warning like this: Place brace on its own line for function definitions. [whitespace/braces] [4]
Attachments
Patch v1
(2.51 KB, patch)
2018-01-23 14:55 PST
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews206 for win-future
(12.01 MB, application/zip)
2018-01-23 19:02 PST
,
EWS Watchlist
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2018-01-23 14:44:14 PST
<
rdar://problem/36449728
>
David Kilzer (:ddkilzer)
Comment 2
2018-01-23 14:55:25 PST
Created
attachment 332081
[details]
Patch v1
EWS Watchlist
Comment 3
2018-01-23 19:02:21 PST
Comment on
attachment 332081
[details]
Patch v1
Attachment 332081
[details]
did not pass win-ews (win): Output:
http://webkit-queues.webkit.org/results/6189452
New failing tests: http/tests/misc/bubble-drag-events.html
EWS Watchlist
Comment 4
2018-01-23 19:02:31 PST
Created
attachment 332117
[details]
Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
David Kilzer (:ddkilzer)
Comment 5
2018-01-24 09:59:30 PST
(In reply to Build Bot from
comment #3
)
> Comment on
attachment 332081
[details]
> Patch v1 > >
Attachment 332081
[details]
did not pass win-ews (win): > Output:
http://webkit-queues.webkit.org/results/6189452
> > New failing tests: > http/tests/misc/bubble-drag-events.html
FYI: There is no possible way this patch can cause a Windows layout test failure as it only changes Python code used by check-webkit-style.
WebKit Commit Bot
Comment 6
2018-01-24 10:11:18 PST
Comment on
attachment 332081
[details]
Patch v1 Clearing flags on attachment: 332081 Committed
r227532
: <
https://trac.webkit.org/changeset/227532
>
WebKit Commit Bot
Comment 7
2018-01-24 10:11:20 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug