WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
182005
[GTK] MiniBrowser settings are just a list of names
https://bugs.webkit.org/show_bug.cgi?id=182005
Summary
[GTK] MiniBrowser settings are just a list of names
Dan Jacobson
Reported
2018-01-23 12:50:57 PST
Please see
https://bugzilla.gnome.org/attachment.cgi?id=367332&action=edit
Nobody can inspect or change the values of items in MiniBrowser, only see their names.
Attachments
Patch
(2.01 KB, patch)
2018-02-01 01:35 PST
,
Carlos Garcia Campos
svillar
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2018-01-23 18:12:11 PST
There is a hidden horizontal scrollbar you can use. Agreed this ought to be better.
Dan Jacobson
Comment 2
2018-01-24 07:53:31 PST
Also that "WebKit View Settings" window: 1. Cannot be expanded, not via a nonexistant fullscreen icon, as all there is is an "X" to close it. Nor does grabbing on its sides actually work! 2. On some screens the "Value" column is visible, on some not. So the smaller terminal people, if never discovering the almost hidden slider, will think there is no value column. And if they discover the slider and slide to see the value, they will have to slide back again to see the name, unless they remember it.
Carlos Garcia Campos
Comment 3
2018-02-01 01:35:06 PST
Created
attachment 332859
[details]
Patch
Sergio Villar Senin
Comment 4
2018-02-01 01:40:12 PST
Comment on
attachment 332859
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=332859&action=review
> Tools/ChangeLog:7 > +
Nit, I'd add something here, just because there is absolutely no connection between the bug title and the fixes you describe bellow.
Carlos Garcia Campos
Comment 5
2018-02-01 01:44:53 PST
Committed
r227957
: <
https://trac.webkit.org/changeset/227957
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug