Bug 182002 - Remove compile guard around beacon API
Summary: Remove compile guard around beacon API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 12:25 PST by Alex Christensen
Modified: 2018-02-21 10:21 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2018-01-23 12:26 PST, Alex Christensen
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-23 12:25:55 PST
Remove compile guard around beacon API
Comment 1 Alex Christensen 2018-01-23 12:26:21 PST
Created attachment 332061 [details]
Patch
Comment 2 Alex Christensen 2018-01-23 15:34:04 PST
https://trac.webkit.org/changeset/227438/webkit
Comment 3 Radar WebKit Bug Importer 2018-01-23 15:35:27 PST
<rdar://problem/36797467>
Comment 4 Chris Dumez 2018-02-20 18:38:50 PST
Comment on attachment 332061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332061&action=review

> Source/WebKit/config.h:-81
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200) || PLATFORM(IOS) || PLATFORM(APPLETV) || PLATFORM(WATCHOS) || USE(SOUP)

Beacon API is not supported on ElCapitan, why are we enabling it unconditionally now?
Comment 5 Alex Christensen 2018-02-21 10:21:28 PST
We don't build for El Capitan any more.