RESOLVED FIXED 181999
DFG should always flush `this` 
https://bugs.webkit.org/show_bug.cgi?id=181999
Summary DFG should always flush `this`
Filip Pizlo
Reported 2018-01-23 11:54:32 PST
Patch forthcoming.
Attachments
the patch (10.69 KB, patch)
2018-01-23 11:58 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2018-01-23 11:58:38 PST
Created attachment 332053 [details] the patch
Saam Barati
Comment 2 2018-01-23 12:06:44 PST
Comment on attachment 332053 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332053&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); This should just go in the above loop and make it loop over the zero index
Mark Lam
Comment 3 2018-01-23 12:09:46 PST
Comment on attachment 332053 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332053&action=review r=me with suggested simplification. > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > + for (unsigned argument = numArguments; argument-- > 1;) > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(argument))); > + > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); Why not just do all the flushing in the for loop? for (unsigned argument = numArguments; argument--;) addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(argument)));
Filip Pizlo
Comment 4 2018-01-23 12:14:51 PST
(In reply to Saam Barati from comment #2) > Comment on attachment 332053 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332053&action=review > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); > > This should just go in the above loop and make it loop over the zero index Oh. Right.
Radar WebKit Bug Importer
Comment 5 2018-01-23 12:15:10 PST
<rdar://problem/36787959>
Filip Pizlo
Comment 6 2018-01-23 12:17:18 PST
Landed in https://trac.webkit.org/changeset/227431/webkit
Note You need to log in before you can comment on or make changes to this bug.