Patch forthcoming.
Created attachment 332053 [details] the patch
Comment on attachment 332053 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332053&action=review > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); This should just go in the above loop and make it loop over the zero index
Comment on attachment 332053 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=332053&action=review r=me with suggested simplification. > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > + for (unsigned argument = numArguments; argument-- > 1;) > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(argument))); > + > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); Why not just do all the flushing in the for loop? for (unsigned argument = numArguments; argument--;) addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(argument)));
(In reply to Saam Barati from comment #2) > Comment on attachment 332053 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=332053&action=review > > > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:539 > > + addFlushDirect(remapOperand(inlineCallFrame, virtualRegisterForArgument(0))); > > This should just go in the above loop and make it loop over the zero index Oh. Right.
<rdar://problem/36787959>
Landed in https://trac.webkit.org/changeset/227431/webkit