Bug 181994 – AX: SVG AAM mapping trumps ARIA role attribute in the case of SVG root

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

We're unconditionally mapping the SVG root to AccessibilityRole::Group as per the SVG AAM. Doing so means any author-provided ARIA role on the SVG root is lost.

[Radar WebKit Bug Importer]

<rdar://problem/36783421>

[Joanmarie Diggs]

Created attachment 332039 [details]
Patch

[EWS Watchlist]

Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184614

New failing tests:
accessibility/svg-element-with-aria-role.html

[EWS Watchlist]

Created attachment 332051 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6184633

New failing tests:
accessibility/svg-element-with-aria-role.html

[EWS Watchlist]

Created attachment 332056 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184664

New failing tests:
accessibility/svg-element-with-aria-role.html

[EWS Watchlist]

Created attachment 332059 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[chris fleizach]

(In reply to Joanmarie Diggs (irc: joanie) from comment #2)
> Created attachment 332039 [details]
> Patch

Approved once failing test is resolved

[Joanmarie Diggs]

Created attachment 332159 [details]
Patch

[Joanmarie Diggs]

Comment on attachment 332159 [details]
Patch

Note that I generated test results for macOS and Linux. I don't have a machine on which to do so for Windows.

[EWS Watchlist]

Comment on attachment 332159 [details]
Patch

Attachment 332159 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6196465

New failing tests:
http/tests/misc/bubble-drag-events.html
accessibility/svg-element-with-aria-role.html

[EWS Watchlist]

Created attachment 332172 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Joanmarie Diggs]

Created attachment 332174 [details]
Patch

[Joanmarie Diggs]

(In reply to Build Bot from comment #12)

> New failing tests:
> http/tests/misc/bubble-drag-events.html

I don't see how this patch can be causing the above.

> accessibility/svg-element-with-aria-role.html

Looks like all SVG accessibility tests are marked as failing for windows. Therefore my just-attached patch adds the new test to that list in TestExpectations.

[WebKit Commit Bot]

Comment on attachment 332174 [details]
Patch

Clearing flags on attachment: 332174

Committed r227536: <https://trac.webkit.org/changeset/227536>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.