Bug 181994 - AX: SVG AAM mapping trumps ARIA role attribute in the case of SVG root
Summary: AX: SVG AAM mapping trumps ARIA role attribute in the case of SVG root
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 10:52 PST by Joanmarie Diggs
Modified: 2018-01-24 11:34 PST (History)
10 users (show)

See Also:


Attachments
Patch (5.09 KB, patch)
2018-01-23 10:55 PST, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.21 MB, application/zip)
2018-01-23 11:55 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.68 MB, application/zip)
2018-01-23 12:00 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews113 for mac-sierra (2.89 MB, application/zip)
2018-01-23 12:20 PST, EWS Watchlist
no flags Details
Patch (5.97 KB, patch)
2018-01-24 07:23 PST, Joanmarie Diggs
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.04 MB, application/zip)
2018-01-24 09:25 PST, EWS Watchlist
no flags Details
Patch (6.76 KB, patch)
2018-01-24 09:55 PST, Joanmarie Diggs
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joanmarie Diggs 2018-01-23 10:52:58 PST
We're unconditionally mapping the SVG root to AccessibilityRole::Group as per the SVG AAM. Doing so means any author-provided ARIA role on the SVG root is lost.
Comment 1 Radar WebKit Bug Importer 2018-01-23 10:53:26 PST
<rdar://problem/36783421>
Comment 2 Joanmarie Diggs 2018-01-23 10:55:12 PST
Created attachment 332039 [details]
Patch
Comment 3 EWS Watchlist 2018-01-23 11:55:29 PST
Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184614

New failing tests:
accessibility/svg-element-with-aria-role.html
Comment 4 EWS Watchlist 2018-01-23 11:55:30 PST
Created attachment 332051 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-01-23 12:00:38 PST
Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6184633

New failing tests:
accessibility/svg-element-with-aria-role.html
Comment 6 EWS Watchlist 2018-01-23 12:00:40 PST
Created attachment 332056 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-01-23 12:20:46 PST
Comment on attachment 332039 [details]
Patch

Attachment 332039 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184664

New failing tests:
accessibility/svg-element-with-aria-role.html
Comment 8 EWS Watchlist 2018-01-23 12:20:47 PST
Created attachment 332059 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 chris fleizach 2018-01-23 17:56:51 PST
(In reply to Joanmarie Diggs (irc: joanie) from comment #2)
> Created attachment 332039 [details]
> Patch

Approved once failing test is resolved
Comment 10 Joanmarie Diggs 2018-01-24 07:23:22 PST
Created attachment 332159 [details]
Patch
Comment 11 Joanmarie Diggs 2018-01-24 09:10:03 PST
Comment on attachment 332159 [details]
Patch

Note that I generated test results for macOS and Linux. I don't have a machine on which to do so for Windows.
Comment 12 EWS Watchlist 2018-01-24 09:25:07 PST
Comment on attachment 332159 [details]
Patch

Attachment 332159 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6196465

New failing tests:
http/tests/misc/bubble-drag-events.html
accessibility/svg-element-with-aria-role.html
Comment 13 EWS Watchlist 2018-01-24 09:25:18 PST
Created attachment 332172 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 14 Joanmarie Diggs 2018-01-24 09:55:05 PST
Created attachment 332174 [details]
Patch
Comment 15 Joanmarie Diggs 2018-01-24 09:57:45 PST
(In reply to Build Bot from comment #12)

> New failing tests:
> http/tests/misc/bubble-drag-events.html

I don't see how this patch can be causing the above.

> accessibility/svg-element-with-aria-role.html

Looks like all SVG accessibility tests are marked as failing for windows. Therefore my just-attached patch adds the new test to that list in TestExpectations.
Comment 16 WebKit Commit Bot 2018-01-24 11:34:55 PST
Comment on attachment 332174 [details]
Patch

Clearing flags on attachment: 332174

Committed r227536: <https://trac.webkit.org/changeset/227536>
Comment 17 WebKit Commit Bot 2018-01-24 11:34:57 PST
All reviewed patches have been landed.  Closing bug.