Bug 181989 - [YARR] Extend size of fixed characters bulk matching in 64bit platform
Summary: [YARR] Extend size of fixed characters bulk matching in 64bit platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 09:55 PST by Yusuke Suzuki
Modified: 2018-08-20 20:30 PDT (History)
8 users (show)

See Also:


Attachments
Patch (13.95 KB, patch)
2018-01-23 10:16 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.17 MB, application/zip)
2018-01-23 11:28 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.62 MB, application/zip)
2018-01-23 11:32 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.97 MB, application/zip)
2018-01-23 11:54 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.30 MB, application/zip)
2018-01-23 15:18 PST, EWS Watchlist
no flags Details
Patch (12.78 KB, patch)
2018-01-28 20:40 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.78 KB, patch)
2018-01-28 20:56 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.82 KB, patch)
2018-01-28 21:47 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (19.47 KB, patch)
2018-06-03 18:02 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (20.64 KB, patch)
2018-06-03 18:23 PDT, Yusuke Suzuki
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-01-23 09:55:55 PST
We can use 64bit registers to perform bulk matching.
Comment 1 Yusuke Suzuki 2018-01-23 10:16:55 PST
Created attachment 332036 [details]
Patch
Comment 2 EWS Watchlist 2018-01-23 10:19:17 PST
Attachment 332036 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:343:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-01-23 11:28:06 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184138

New failing tests:
js/regexp-unicode.html
Comment 4 EWS Watchlist 2018-01-23 11:28:07 PST
Created attachment 332046 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-01-23 11:32:27 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6184155

New failing tests:
js/regexp-unicode.html
Comment 6 EWS Watchlist 2018-01-23 11:32:28 PST
Created attachment 332047 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-01-23 11:54:42 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6184260

New failing tests:
js/regexp-unicode.html
Comment 8 EWS Watchlist 2018-01-23 11:54:43 PST
Created attachment 332050 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-01-23 13:35:53 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6185745

New failing tests:
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-ftl
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-llint
es6.yaml/es6/RegExp_y_and_u_flags_u_flag_Unicode_code_point_escapes.js.default
Comment 10 EWS Watchlist 2018-01-23 15:18:30 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6186611

New failing tests:
js/regexp-unicode.html
fast/text/combining-character-sequence-fallback-crash.html
Comment 11 EWS Watchlist 2018-01-23 15:18:31 PST
Created attachment 332083 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 12 EWS Watchlist 2018-01-23 18:17:07 PST
Comment on attachment 332036 [details]
Patch

Attachment 332036 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/6185742

New failing tests:
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-ftl
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-dfg-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/regexp-unicode.js.layout-no-llint
es6.yaml/es6/RegExp_y_and_u_flags_u_flag_Unicode_code_point_escapes.js.default
Comment 13 Yusuke Suzuki 2018-01-28 20:40:08 PST
Created attachment 332505 [details]
Patch
Comment 14 EWS Watchlist 2018-01-28 20:42:01 PST
Attachment 332505 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:343:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Yusuke Suzuki 2018-01-28 20:56:44 PST
Created attachment 332506 [details]
Patch
Comment 16 EWS Watchlist 2018-01-28 20:58:59 PST
Attachment 332506 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:343:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 Yusuke Suzuki 2018-01-28 21:47:02 PST
Created attachment 332507 [details]
Patch
Comment 18 EWS Watchlist 2018-01-28 21:48:59 PST
Attachment 332507 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:343:  Wrong number of spaces before statement. (expected: 9)  [whitespace/indent] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 Yusuke Suzuki 2018-06-03 18:02:23 PDT
Created attachment 341881 [details]
Patch
Comment 20 EWS Watchlist 2018-06-03 18:03:45 PDT
Attachment 341881 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:386:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 Yusuke Suzuki 2018-06-03 18:23:19 PDT
Created attachment 341883 [details]
Patch
Comment 22 EWS Watchlist 2018-06-03 18:25:48 PDT
Attachment 341883 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/assembler/LinkBuffer.h:386:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 23 Yusuke Suzuki 2018-06-07 19:08:11 PDT
Ping?
Comment 24 Yusuke Suzuki 2018-06-12 04:20:50 PDT
Michael, can you take a look?
Comment 25 Yusuke Suzuki 2018-06-29 07:22:05 PDT
Ping?
Comment 26 Yusuke Suzuki 2018-07-26 16:04:09 PDT
Ping?
Comment 27 Michael Saboff 2018-08-20 12:08:52 PDT
Comment on attachment 341883 [details]
Patch

r=me
Sorry for the review delay.
You may need to rebase due to recent RegExp disassembly changes.
Comment 28 Yusuke Suzuki 2018-08-20 20:14:09 PDT
(In reply to Michael Saboff from comment #27)
> Comment on attachment 341883 [details]
> Patch
> 
> r=me
> Sorry for the review delay.
> You may need to rebase due to recent RegExp disassembly changes.

Thanks! Fixed.
Comment 29 Yusuke Suzuki 2018-08-20 20:29:38 PDT
Committed r235104: <https://trac.webkit.org/changeset/235104>
Comment 30 Radar WebKit Bug Importer 2018-08-20 20:30:39 PDT
<rdar://problem/43542780>