Bug 181984 - WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::test_merge_platformName fails
Summary: WebDriver: test imported/w3c/webdriver/tests/sessions/new_session/merge.py::t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 06:44 PST by Carlos Garcia Campos
Modified: 2018-01-25 05:52 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.20 KB, patch)
2018-01-24 05:23 PST, Carlos Garcia Campos
clopez: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (2.21 MB, application/zip)
2018-01-24 06:52 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-01-23 06:44:31 PST
Seems to be a matter of doing case insensitive cmp.

__________________________________________________________________________________ test_merge_platformName ___________________________________________________________________________________

new_session = <function create_session at 0x7fa92c0b2b18>, add_browser_capabilites = <function update_capabilities at 0x7fa92c0b2b90>, platform_name = 'linux'

    @pytest.mark.skipif(platform_name() is None, reason="Unsupported platform")
    def test_merge_platformName(new_session, add_browser_capabilites, platform_name):
        resp, _ = new_session({"capabilities":
                            {"alwaysMatch": add_browser_capabilites({"timeouts": {"script": 10}}),
                            "firstMatch": [
                                {
                                    "platformName": platform_name.upper(),
                                    "pageLoadStrategy": "none"
                                },
                                {
                                    "platformName": platform_name,
                                    "pageLoadStrategy": "eager"
                                }
                            ]}})
    
>       assert resp["capabilities"]["platformName"] == platform_name
E       AssertionError: assert 'LINUX' == 'linux'
E         - LINUX
E         + linux

_          = <webdriver.client.Session object at 0x7fa92c0753d0>
add_browser_capabilites = <function update_capabilities at 0x7fa92c0b2b90>
new_session = <function create_session at 0x7fa92c0b2b18>
platform_name = 'linux'
resp       = {'capabilities': {'acceptInsecureCerts': False, 'browserName': 'MiniBrowser', 'browserVersion': '2.19.6', 'pageLoadStrategy': 'none', ...}, 'sessionId': 'b0973e15-e57f-472e-9251-5cf5101bb437'}

WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/merge.py:54: AssertionError
Comment 1 Carlos Garcia Campos 2018-01-24 05:23:09 PST
Created attachment 332148 [details]
Patch
Comment 2 EWS Watchlist 2018-01-24 06:52:25 PST
Comment on attachment 332148 [details]
Patch

Attachment 332148 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6194686

New failing tests:
fast/text/combining-character-sequence-fallback-crash.html
Comment 3 EWS Watchlist 2018-01-24 06:52:26 PST
Created attachment 332153 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 4 Carlos Garcia Campos 2018-01-25 05:51:20 PST
Committed r227602: <https://trac.webkit.org/changeset/227602>
Comment 5 Radar WebKit Bug Importer 2018-01-25 05:52:21 PST
<rdar://problem/36865230>