Bug 181976 - Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum list.
Summary: Re-arrange TypedArray JSTypes to match the order of the TypedArrayType enum l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-23 00:49 PST by Mark Lam
Modified: 2018-01-23 23:04 PST (History)
9 users (show)

See Also:


Attachments
proposed patch. (18.60 KB, patch)
2018-01-23 11:18 PST, Mark Lam
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-01-23 00:49:17 PST
This simplifies the code and makes it easier to map from one to the other.
Comment 1 Radar WebKit Bug Importer 2018-01-23 00:50:33 PST
<rdar://problem/36766936>
Comment 2 Mark Lam 2018-01-23 11:18:58 PST
Created attachment 332043 [details]
proposed patch.
Comment 3 EWS Watchlist 2018-01-23 11:20:15 PST
Attachment 332043 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/TypedArrayType.h:59:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WARNING: This machine could support 4 simulators, but is only configured for 3.
WARNING: Please see <https://trac.webkit.org/wiki/IncreasingKernelLimits>.
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2018-01-23 12:40:14 PST
Thanks for the review.  Landed in r227434: <http://trac.webkit.org/r227434>.
Comment 5 Yusuke Suzuki 2018-01-23 23:04:12 PST
Committed r227478: <https://trac.webkit.org/changeset/227478>