Bug 181961 - Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
Summary: Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-22 16:31 PST by Alex Christensen
Modified: 2018-01-23 15:34 PST (History)
10 users (show)

See Also:


Attachments
Patch (34.61 KB, patch)
2018-01-22 16:33 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (35.76 KB, patch)
2018-01-22 17:05 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (35.90 KB, patch)
2018-01-22 18:00 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (36.31 KB, patch)
2018-01-23 12:19 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (36.14 KB, patch)
2018-01-23 13:37 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (37.63 KB, patch)
2018-01-23 14:33 PST, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-01-22 16:31:32 PST
Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
Comment 1 Alex Christensen 2018-01-22 16:33:11 PST
Created attachment 331976 [details]
Patch
Comment 2 Alex Christensen 2018-01-22 17:05:48 PST
Created attachment 331981 [details]
Patch
Comment 3 Michael Catanzaro 2018-01-22 17:58:22 PST
Comment on attachment 331981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331981&action=review

This looks easier to read! r=me if you can get it past the Windows EWS.

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:217
> +    didReceiveResponse(ResourceResponse(d->m_response), [this, protectedThis = makeRef(*this)] {

Failed to run "['perl', 'Tools\\Scripts\\build-webkit', '--release', '--wincairo', '--64-bit']" exit_code: 1
oid (void)> &&)': cannot convert argument 2 from 'WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential::<lambda_af02a6328e703639d69ef207f72ddd9e>' to 'WTF::CompletionHandler<void (void)> &&'
..\..\Source\WebCore\platform\network\curl\ResourceHandleCurl.cpp(222): note: Reason: cannot convert from 'WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential::<lambda_af02a6328e703639d69ef207f72ddd9e>' to 'WTF::CompletionHandler<void (void)>'
..\..\Source\WebCore\platform\network\curl\ResourceHandleCurl.cpp(222): note: use of undefined type 'WTF::CompletionHandler<void (void)>'
C:\WebKit-EWS\WebKit\Source\WebCore\platform\network\ResourceHandle.h(110): note: see declaration of 'WTF::CompletionHandler<void (void)>'
Comment 4 Alex Christensen 2018-01-22 18:00:57 PST
Created attachment 331991 [details]
Patch
Comment 5 Alex Christensen 2018-01-23 12:19:25 PST
Created attachment 332058 [details]
Patch
Comment 6 Alex Christensen 2018-01-23 13:37:24 PST
Created attachment 332068 [details]
Patch
Comment 7 Alex Christensen 2018-01-23 14:33:55 PST
Created attachment 332078 [details]
Patch
Comment 8 Alex Christensen 2018-01-23 15:33:25 PST
https://trac.webkit.org/changeset/227455/webkit
Comment 9 Radar WebKit Bug Importer 2018-01-23 15:34:37 PST
<rdar://problem/36797428>