Bug 181955 - Mac Sierra perf bots have been failing due to CG errors
Summary: Mac Sierra perf bots have been failing due to CG errors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-22 14:46 PST by Ryosuke Niwa
Modified: 2018-01-23 16:31 PST (History)
10 users (show)

See Also:


Attachments
Ignores the erorr messages on macOS Sierra (7.24 KB, patch)
2018-01-22 14:50 PST, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-22 14:46:02 PST
All perf tests are failing due to CoreGraphics spewing errors
Comment 1 Simon Fraser (smfr) 2018-01-22 14:49:57 PST
We should make perf bots ignore all output except for the lines they expect.
Comment 2 Ryosuke Niwa 2018-01-22 14:50:23 PST
Created attachment 331966 [details]
Ignores the erorr messages on macOS Sierra
Comment 3 Alexey Proskuryakov 2018-01-22 14:55:51 PST
Comment on attachment 331966 [details]
Ignores the erorr messages on macOS Sierra

View in context: https://bugs.webkit.org/attachment.cgi?id=331966&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:266
> +        # GC errors on macOS 10.12.6

CG. These also happen on High Sierra, although we don't have any bots.
Comment 4 Ryosuke Niwa 2018-01-22 16:15:59 PST
(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 331966 [details]
> Ignores the erorr messages on macOS Sierra
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331966&action=review
> 
> > Tools/Scripts/webkitpy/performance_tests/perftest.py:266
> > +        # GC errors on macOS 10.12.6
> 
> CG. These also happen on High Sierra, although we don't have any bots.

Hm... I've tried it on my High Sierra machine, and I don't see the same errors.
Comment 5 Alexey Proskuryakov 2018-01-22 16:26:21 PST
Surprisingly, I don't seem to hit these on mine either. Okay.

Probably best for someone with more Python knowledge than myself to review the patch.
Comment 6 Ryosuke Niwa 2018-01-23 16:30:09 PST
Committed r227460: <https://trac.webkit.org/changeset/227460>
Comment 7 Radar WebKit Bug Importer 2018-01-23 16:31:36 PST
<rdar://problem/36799878>