Bug 181920 - Turning off custom pasteboard data doesn't actually turn it off in WK2
Summary: Turning off custom pasteboard data doesn't actually turn it off in WK2
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Blocks: 181616
  Show dependency treegraph
Reported: 2018-01-21 20:44 PST by Ryosuke Niwa
Modified: 2018-01-21 22:41 PST (History)
4 users (show)

See Also:

Fixes the bug (19.71 KB, patch)
2018-01-21 20:49 PST, Ryosuke Niwa
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-01-21 20:44:33 PST
We have a bug that turning off custom pasteboard data in WK2 doesn’t actually turn it off because defaultCustomPasteboardDataEnabled() returns false in UIProcess, and WebPreferenceStore ends up not updating the preferences after https://trac.webkit.org/changeset/226156.

We should simply replace this crazy global settings by a regular runtime enabled flag.
Comment 1 Ryosuke Niwa 2018-01-21 20:45:22 PST
Comment 2 Ryosuke Niwa 2018-01-21 20:49:55 PST
Created attachment 331893 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2018-01-21 22:39:26 PST
Thanks for the review!
Comment 4 Ryosuke Niwa 2018-01-21 22:41:07 PST
Committed r227282: <https://trac.webkit.org/changeset/227282>