Resign NowPlaying status when no media element is eligible.
<rdar://problem/35294116>
Created attachment 331874 [details] Patch
Comment on attachment 331874 [details] Patch Clearing flags on attachment: 331874 Committed r227279: <https://trac.webkit.org/changeset/227279>
All reviewed patches have been landed. Closing bug.
This change appears to have caused an assertion failure, seen here with media/video-main-content-autoplay.html: ASSERTION FAILED: isSafeToUpdateStyleOrLayout() /Volumes/Data/slave/highsierra-debug/build/Source/WebCore/dom/Document.cpp(1980) : void WebCore::Document::updateLayout() https://build.webkit.org/results/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/r227291%20(1718)/results.html
I can reproduce the crash with a build of r227279 using the following command: run-webkit-tests media/video-main-content-autoplay.html media/video-main-content-deny-obscured.html -fg --iter 10 --no-retry I cannot reproduce with a build of r227278.
The same crash is also happening with the test media/video-main-content-allow-then-scroll.html
Created attachment 331963 [details] Fix crashing tests.
Reopening to land patch.
Created attachment 331977 [details] Patch to fix test crashes Attaching patch again to trigger EWS.
Comment on attachment 331977 [details] Patch to fix test crashes Clearing flags on attachment: 331977 Committed r227373: <https://trac.webkit.org/changeset/227373>
API test NowPlayingControlsTests.NowPlayingControlsCheckRegistered is timing out after https://trac.webkit.org/changeset/227373
*** Bug 181987 has been marked as a duplicate of this bug. ***
Re-opened since this is blocked by bug 181988
Rolled out in https://trac.webkit.org/changeset/227422
Created attachment 332073 [details] Patch
Comment on attachment 332073 [details] Patch Clearing flags on attachment: 332073 Committed r227457: <https://trac.webkit.org/changeset/227457>
Looks like this introduced a new crash: https://bugs.webkit.org/show_bug.cgi?id=182038 We can't trigger a layout within removedFromAncestor