RESOLVED FIXED 181909
Fix broken unit-tests after r227192 
https://bugs.webkit.org/show_bug.cgi?id=181909
Summary Fix broken unit-tests after r227192
Aakash Jain
Reported 2018-01-20 16:02:23 PST
https://trac.webkit.org/changeset/227192/webkit broke few unit-tests. e.g.: FAIL: test_builder GTK Linux 64-bit Release (Tests) (__main__.BuildStepsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "./steps_unittest.py", line 488, in doTest self.assertListEqual(expected_build_steps[builder['name']], buildSteps) AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki... Second list contains 1 additional elements. First extra element 19: webdriver-test ['configure build', 'svn', 'kill old processes', 'delete WebKitBuild directory', 'delete stale build files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand', - 'API tests'] ? ^ + 'API tests', ? ^ + 'webdriver-test']
Attachments
Proposed patch (6.27 KB, patch)
2018-01-20 16:04 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-01-20 16:04:41 PST
Created attachment 331849 [details] Proposed patch
Carlos Garcia Campos
Comment 2 2018-01-21 00:33:43 PST
Comment on attachment 331849 [details] Proposed patch Sorry, I didn't notice it. Thanks for fixing it.
WebKit Commit Bot
Comment 3 2018-01-21 00:57:21 PST
Comment on attachment 331849 [details] Proposed patch Clearing flags on attachment: 331849 Committed r227276: <https://trac.webkit.org/changeset/227276>
WebKit Commit Bot
Comment 4 2018-01-21 00:57:22 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-01-21 00:58:27 PST
<rdar://problem/36704843>
Note You need to log in before you can comment on or make changes to this bug.