Bug 181909 - Fix broken unit-tests after r227192
Summary: Fix broken unit-tests after r227192
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-20 16:02 PST by Aakash Jain
Modified: 2018-01-21 00:58 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (6.27 KB, patch)
2018-01-20 16:04 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-01-20 16:02:23 PST 
https://trac.webkit.org/changeset/227192/webkit broke few unit-tests. e.g.:

FAIL: test_builder GTK Linux 64-bit Release (Tests) (__main__.BuildStepsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./steps_unittest.py", line 488, in doTest
    self.assertListEqual(expected_build_steps[builder['name']], buildSteps)
AssertionError: Lists differ: ['configure build', 'svn', 'ki... != ['configure build', 'svn', 'ki...

Second list contains 1 additional elements.
First extra element 19:
webdriver-test

  ['configure build',
   'svn',
   'kill old processes',
   'delete WebKitBuild directory',
   'delete stale build files',
   'jhbuild',
   'download-built-product',
   'extract-built-product',
   'jscore-test',
   'layout-test',
   'webkitpy-test',
   'webkitperl-test',
   'bindings-generation-tests',
   'builtins-generator-tests',
   'dashboard-tests',
   'archive-test-results',
   'upload',
   'MasterShellCommand',
-  'API tests']
?             ^

+  'API tests',
?             ^

+  'webdriver-test']
Comment 1 Aakash Jain 2018-01-20 16:04:41 PST 
Created attachment 331849 [details]
Proposed patch
Comment 2 Carlos Garcia Campos 2018-01-21 00:33:43 PST 
Comment on attachment 331849 [details]
Proposed patch

Sorry, I didn't notice it. Thanks for fixing it.
Comment 3 WebKit Commit Bot 2018-01-21 00:57:21 PST 
Comment on attachment 331849 [details]
Proposed patch

Clearing flags on attachment: 331849

Committed r227276: <https://trac.webkit.org/changeset/227276>
Comment 4 WebKit Commit Bot 2018-01-21 00:57:22 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-21 00:58:27 PST 
<rdar://problem/36704843>