Bug 181906 - Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not.
Summary: Extend 'ifBuilt' config key to set property based on whether certain reposito...
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2018-01-20 02:52 PST by dewei_zhu
Modified: 2022-10-05 16:15 PDT (History)
3 users (show)

See Also:

Patch (9.37 KB, patch)
2018-01-20 02:54 PST, dewei_zhu
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-01-20 02:52:01 PST
Extend 'ifBuilt' config key to set property based on whether certain repositories are built or not.
Comment 1 dewei_zhu 2018-01-20 02:54:18 PST
Created attachment 331839 [details]
Comment 2 Ryosuke Niwa 2018-01-22 12:29:09 PST
Comment on attachment 331839 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=331839&action=review

> Websites/perf.webkit.org/ChangeLog:9
> +        'ifBuilt' need to conditionally set property based on whether certain required repositories are built.
> +        Empty required repository list means no requirement on repository to set property.

Please explain why we're making this change in the change log.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:287
> +                    const meetRepositoryRequirement = repositoryRequirement.length === 0 || repositoryRequirement.some((repository) => commitSet.requiresBuildForRepository(repository));

Use !repositoryRequirement.length instead of === 0.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1075
> +        it('should resolve "ifBuilt" with repositories to check', () => {

Should be rephrased as: should set the value for "ifBuilt" if the repository in the list appears.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:1103
> +        it('should resolve "ifBuilt" with if only owned commits need build', () => {

Should re be rephrase as: should not set the value for "ifBuilt" if owned commits of a repository not in the list appears.
Comment 3 Ahmad Saleem 2022-10-05 15:56:38 PDT
This seems to have landed in below commit:


and not backed out. I am marking this as "RESOLVED FIXED". Thanks!
Comment 4 dewei_zhu 2022-10-05 16:15:27 PDT
Yes, it is. Thanks!