Bug 181895 - Temporarily restore block selection code conditionally
Summary: Temporarily restore block selection code conditionally
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-19 18:12 PST by Megan Gardner
Modified: 2018-01-22 17:46 PST (History)
4 users (show)

See Also:


Attachments
Patch (33.19 KB, patch)
2018-01-19 19:52 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (33.19 KB, patch)
2018-01-20 19:52 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (33.88 KB, patch)
2018-01-22 11:33 PST, Megan Gardner
no flags Details | Formatted Diff | Diff
Patch (34.55 KB, patch)
2018-01-22 12:55 PST, Megan Gardner
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-01-19 18:12:37 PST
Temporarily restore some selection methods
Comment 1 Megan Gardner 2018-01-19 19:52:26 PST
Created attachment 331829 [details]
Patch
Comment 2 Megan Gardner 2018-01-19 19:53:43 PST
<rdar://problem/36567325>
Comment 3 Tim Horton 2018-01-19 21:35:10 PST
Comment on attachment 331829 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331829&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:618
> +- (void)changeBlockSelectionWithTouchAt:(CGPoint)point withSelectionTouch:(UIWKSelectionTouch)touch forHandle:(UIWKHandlePosition)handle;

Semicolons and curly braces and stuff oh my!
Comment 4 Megan Gardner 2018-01-20 19:52:08 PST
Created attachment 331855 [details]
Patch
Comment 5 Tim Horton 2018-01-21 11:05:07 PST
Still doesn’t build.
Comment 6 Wenson Hsieh 2018-01-21 14:06:33 PST
Looks like we need to re-teach UIKitSPI.h about UIWKHandlePosition.
Comment 7 Simon Fraser (smfr) 2018-01-22 10:29:52 PST
Can we add a test?
Comment 8 Megan Gardner 2018-01-22 11:33:02 PST
Created attachment 331945 [details]
Patch
Comment 9 Megan Gardner 2018-01-22 12:55:20 PST
Created attachment 331951 [details]
Patch
Comment 10 Tim Horton 2018-01-22 13:04:21 PST
Comment on attachment 331951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331951&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2638
> +    // This was only readded to avoid a crash due to incombatabliltiese with certain version of UIKit.

> incombatabliltiese
Comment 11 Megan Gardner 2018-01-22 13:51:53 PST
https://trac.webkit.org/changeset/227355/webkit
Comment 12 Megan Gardner 2018-01-22 17:46:28 PST
https://trac.webkit.org/changeset/227377/webkit