Should reject updating a 'completed' build request.
Created attachment 331833 [details] Patch
Comment on attachment 331833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331833&action=review > Websites/perf.webkit.org/public/include/report-processor.php:146 > - if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id), array('status' => 'completed', 'build' => $build_id)) > + if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id, 'build' => null), array('status' => 'completed', 'build' => $build_id)) We need to this check before build row is created. > Websites/perf.webkit.org/server-tests/api-report-tests.js:784 > + assert.equal(response['status'], 'OK'); > + return TestServer.remoteAPI().postJSON('/api/report/', [anotherReportWithSameBuildRequest]); As I mentioned, we should check that this didn't create a new build entry.
Comment on attachment 331833 [details] Patch r- because we shouldn't be creating zombie build entires in the database.
Created attachment 331836 [details] Patch