NEW 181893
Should reject updating a build request which has an associated build. 
https://bugs.webkit.org/show_bug.cgi?id=181893
Summary Should reject updating a build request which has an associated build.
dewei_zhu
Reported 2018-01-19 17:33:59 PST
Should reject updating a 'completed' build request.
Attachments
Patch (5.91 KB, patch)
2018-01-19 22:53 PST, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (11.88 KB, patch)
2018-01-20 00:01 PST, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2018-01-19 22:53:38 PST
Created attachment 331833 [details] Patch
Ryosuke Niwa
Comment 2 2018-01-19 22:56:41 PST
Comment on attachment 331833 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=331833&action=review > Websites/perf.webkit.org/public/include/report-processor.php:146 > - if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id), array('status' => 'completed', 'build' => $build_id)) > + if ($this->db->update_row('build_requests', 'request', array('id' => $build_request_id, 'build' => null), array('status' => 'completed', 'build' => $build_id)) We need to this check before build row is created. > Websites/perf.webkit.org/server-tests/api-report-tests.js:784 > + assert.equal(response['status'], 'OK'); > + return TestServer.remoteAPI().postJSON('/api/report/', [anotherReportWithSameBuildRequest]); As I mentioned, we should check that this didn't create a new build entry.
Ryosuke Niwa
Comment 3 2018-01-19 23:18:38 PST
Comment on attachment 331833 [details] Patch r- because we shouldn't be creating zombie build entires in the database.
dewei_zhu
Comment 4 2018-01-20 00:01:59 PST
Created attachment 331836 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.