Bug 181892 - Add a new logging specialization for count data
Summary: Add a new logging specialization for count data
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-19 17:32 PST by Brent Fulgham
Modified: 2021-03-17 15:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (29.52 KB, patch)
2018-01-19 17:38 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (35.22 KB, patch)
2018-01-21 12:15 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (35.22 KB, patch)
2018-01-21 12:47 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-01-19 17:32:38 PST 
WebKit telemetry data is currently captured as strings in many cases, which can make evaluating the data difficult. We should take advantage of the native logging infrastructure's ability to handle integer types, and pass counts as integers.
Comment 1 Radar WebKit Bug Importer 2018-01-19 17:35:58 PST 
<rdar://problem/36677978>
Comment 2 Brent Fulgham 2018-01-19 17:38:53 PST 
Created attachment 331826 [details]
Patch
Comment 3 Brent Fulgham 2018-01-21 12:15:27 PST 
Created attachment 331877 [details]
Patch
Comment 4 Brent Fulgham 2018-01-21 12:44:57 PST 
Comment on attachment 331877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331877&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:45
> +- (void)_webView:(WKWebView *)webView logDiagnosticMessageWithCount:(NSString *)message description:(NSString *)description count:(NSUInteger) count WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

Whoops! This should be uint64_t for consistency.
Comment 5 Brent Fulgham 2018-01-21 12:47:10 PST 
Created attachment 331880 [details]
Patch
Comment 6 Brent Fulgham 2018-01-22 15:48:54 PST 
I talked to Chris about this (he wrote the initial code), and we decided this should be addressed on the Safari side. I'll close this as NTBF.