Bug 181887 – DOMCache data sometimes not properly removed when clearing data for a given origin

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[Chris Dumez]

DOMCache data sometimes not properly removed when clearing data for a given origin.

[Chris Dumez]

<rdar://problem/36671239>

[Chris Dumez]

Created attachment 331798 [details]
Patch

[EWS Watchlist]

Comment on attachment 331798 [details]
Patch

Attachment 331798 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6142359

New failing tests:
imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-a-bitrate.html

[EWS Watchlist]

Created attachment 331812 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

[youenn fablet]

Comment on attachment 331798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331798&action=review

> Source/WebKit/ChangeLog:15
> +        generated by cachesRootPath(*folderOrigin) differed from the actual folder path

Either the salt is different or the stored data is corrupted.
Maybe there was a conflict with cached data stored by a WebKit that was not partitioning based on ClientOrigin?
We probably should add a version number like we did for service worker paths.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:423
> +            m_ioQueue->dispatch([path = folderPath.isolatedCopy(), taskHandler = WTFMove(taskHandler)] {

Can you add an ASSERT(folderPath == cachesRootPath(*folderOrigin)) ?

[youenn fablet]

(In reply to youenn fablet from comment #5)
> Comment on attachment 331798 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331798&action=review
> 
> > Source/WebKit/ChangeLog:15
> > +        generated by cachesRootPath(*folderOrigin) differed from the actual folder path
> 
> Either the salt is different or the stored data is corrupted.
> Maybe there was a conflict with cached data stored by a WebKit that was not
> partitioning based on ClientOrigin?
> We probably should add a version number like we did for service worker paths.
> 
> > Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:423
> > +            m_ioQueue->dispatch([path = folderPath.isolatedCopy(), taskHandler = WTFMove(taskHandler)] {
> 
> Can you add an ASSERT(folderPath == cachesRootPath(*folderOrigin)) ?

Let's do that as a follow-up.
Landing patch as is for now.

[WebKit Commit Bot]

Comment on attachment 331798 [details]
Patch

Clearing flags on attachment: 331798

Committed r227269: <https://trac.webkit.org/changeset/227269>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.