Bug 181876 - [Curl] Add timeout support to XMLHttpRequest
Summary: [Curl] Add timeout support to XMLHttpRequest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 117300
  Show dependency tree / graph
 
Reported: 2018-01-19 13:10 PST by Basuke Suzuki
Modified: 2018-01-19 14:34 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.60 KB, patch)
2018-01-19 13:15 PST, Basuke Suzuki 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
Fixed (5.57 KB, patch)
2018-01-19 13:27 PST, Basuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-01-19 13:10:29 PST 
Add timeout support to XMLHttpRequest
Comment 1 Basuke Suzuki 2018-01-19 13:15:21 PST 
Created attachment 331775 [details]
Patch
Comment 2 Alex Christensen 2018-01-19 13:22:10 PST 
Comment on attachment 331775 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331775&action=review

> Source/WebCore/platform/network/ResourceRequestBase.cpp:36
> -#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION))
> +#if !USE(SOUP) && (!PLATFORM(MAC) || USE(CFURLCONNECTION)) && !USE(CURL)

Let's change this to #if PLATFORM(IOS) || USE(CFURLCONNECTION)
Comment 3 Basuke Suzuki 2018-01-19 13:27:35 PST 
Created attachment 331782 [details]
Fixed

Okay, change the ifdef condition much simpler
Comment 4 WebKit Commit Bot 2018-01-19 14:33:56 PST 
Comment on attachment 331782 [details]
Fixed

Clearing flags on attachment: 331782

Committed r227237: <https://trac.webkit.org/changeset/227237>
Comment 5 WebKit Commit Bot 2018-01-19 14:33:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-19 14:34:23 PST 
<rdar://problem/36671458>