Bug 181858 - [EME][GStreamer] Add a new message "decrypt-key-needed" send from the decryptor to the application.
Summary: [EME][GStreamer] Add a new message "decrypt-key-needed" send from the decrypt...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 181855
  Show dependency treegraph
Reported: 2018-01-19 08:54 PST by Yacine Bandou
Modified: 2018-04-27 00:27 PDT (History)
6 users (show)

See Also:

Patch (5.63 KB, patch)
2018-01-19 09:15 PST, Yacine Bandou
no flags Details | Formatted Diff | Diff
Patch (6.11 KB, patch)
2018-01-22 05:25 PST, Yacine Bandou
no flags Details | Formatted Diff | Diff
Patch (5.83 KB, patch)
2018-01-22 05:33 PST, Yacine Bandou
no flags Details | Formatted Diff | Diff
Patch (5.83 KB, patch)
2018-04-26 09:08 PDT, Yacine Bandou
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yacine Bandou 2018-01-19 08:54:37 PST
Add a new message "decrypt-key-needed" that the decryptor can send when it doesn't have an available key.
This message should be handled by the application in order to dispatch or send the key to the decryptor.

This patch is a preparation for the patch 181855.

With the patch 181855, the decryptor will be in the PlaybackPipeline instead of AppendPipeline, thus we can
get the DRM license or key before to instantiate or load the decryptor plugin in PlaybackPipeline.
When the decryptor plugin is instantiated or loaded, it should able to ask the application to resend
the DRM license or key by using this new message "decrypt-key-needed".
Comment 1 Yacine Bandou 2018-01-19 09:15:28 PST
Created attachment 331738 [details]
Comment 2 Carlos Alberto Lopez Perez 2018-01-19 09:26:59 PST
Comment on attachment 331738 [details]

r- due to failed GTK EWS. Please try to fix the build there. https://webkit-queues.webkit.org/results/6136390
Comment 3 Yacine Bandou 2018-01-22 05:25:16 PST
Created attachment 331918 [details]
Comment 4 Yacine Bandou 2018-01-22 05:33:41 PST
Created attachment 331919 [details]
Comment 5 Xabier Rodríguez Calvar 2018-04-26 04:35:01 PDT
Comment on attachment 331919 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=331919&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:1212
> +    // This function dispatches the CDMInstance in GStreamer pipeline playback.

pipeline playback -> playback pipeline.
Comment 6 Yacine Bandou 2018-04-26 09:08:02 PDT
Created attachment 338876 [details]
Comment 7 WebKit Commit Bot 2018-04-27 00:27:50 PDT
Comment on attachment 338876 [details]

Clearing flags on attachment: 338876

Committed r231088: <https://trac.webkit.org/changeset/231088>
Comment 8 WebKit Commit Bot 2018-04-27 00:27:52 PDT
All reviewed patches have been landed.  Closing bug.