Bug 181857 – [Web Animations] Expose timing properties (delay, endDelay, fill, iterationStart, iterations, direction) and getComputedTiming()

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

We need to expose most of the timing properties on AnimationEffecTiming, namely:

- delay
- endDelay
- fill
- iterationStart
- iterations
- direction

… and also AnimationEffect::getComputedTiming() which exposes the computed values for those properties and some of the already-exposed properties.

[Radar WebKit Bug Importer]

<rdar://problem/36660081>

[Antoine Quint]

Created attachment 331739 [details]
Patch

[EWS Watchlist]

Attachment 331739 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:20:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antoine Quint]

Created attachment 331740 [details]
Patch

[Dean Jackson]

Comment on attachment 331740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331740&action=review

> Source/WebCore/animation/AnimationEffect.cpp:65
> +    else
> +        computedTiming.localTime = std::nullopt;

Wouldn't this be the default value anyway?

> Source/WebCore/animation/ComputedTimingProperties.h:38
> +    double endTime;
> +    double activeDuration;
> +    std::optional<double> localTime;
> +    std::optional<double> progress;
> +    std::optional<double> currentIteration;

Add some default values here.

> Source/WebCore/animation/WebAnimationUtilities.h:32
> +inline double secondsToWebAnimationsAPITime(const Seconds time)

Could you just put this in an existing header that is already included by everything?

[Antoine Quint]

(In reply to Dean Jackson from comment #5)
> Comment on attachment 331740 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331740&action=review
> 
> > Source/WebCore/animation/AnimationEffect.cpp:65
> > +    else
> > +        computedTiming.localTime = std::nullopt;
> 
> Wouldn't this be the default value anyway?

Good point, I'll check.

> > Source/WebCore/animation/ComputedTimingProperties.h:38
> > +    double endTime;
> > +    double activeDuration;
> > +    std::optional<double> localTime;
> > +    std::optional<double> progress;
> > +    std::optional<double> currentIteration;
> 
> Add some default values here.

These are _always_ computed, I'm not sure there's any value in that.

> > Source/WebCore/animation/WebAnimationUtilities.h:32
> > +inline double secondsToWebAnimationsAPITime(const Seconds time)
> 
> Could you just put this in an existing header that is already included by
> everything?

None that I could find.

[Antoine Quint]

Committed r227208: <https://trac.webkit.org/changeset/227208>