Bug 181847 - [GTK] TERM environment variable is not passed to the test driver.
Summary: [GTK] TERM environment variable is not passed to the test driver.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-19 04:15 PST by Carlos Alberto Lopez Perez
Modified: 2018-01-19 04:23 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2018-01-19 04:15:40 PST 
The TERM environment variable is used to tell the capabilities of the terminal to the running process.
On most of the GTK/WPE bots we set this to TERM=dumb so the tests don't generate ANSI color codes that just look bad on the txt/html files generated by buildbot and make reading the results harder.

We noticed color codes are happening on the new webdriver tests even with this variable.
It looks we are not letting the driver pick this variable, so when pytest is invoked it can't see it.

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/5131/steps/webdriver-test/logs/stdio
Comment 1 Carlos Alberto Lopez Perez 2018-01-19 04:22:09 PST 
Committed r227195: <https://trac.webkit.org/changeset/227195>
Comment 2 Radar WebKit Bug Importer 2018-01-19 04:23:20 PST 
<rdar://problem/36654987>