Created attachment 331705 [details] Crash log The following assertion failure is seen on Sierra Debug WK2 with LayoutTest http/tests/ssl/applepay/ApplePayRequestShippingContact.https.html ASSERTION FAILED: paymentCoordinator().supportsVersion(version) /Volumes/Data/slave/sierra-debug/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp(413) : virtual unsigned int WebCore::ApplePayPaymentHandler::version() const 1 0x108c8bc9d WTFCrash 2 0x10d780157 WebCore::ApplePayPaymentHandler::version() const 3 0x10d7803bf WebCore::ApplePayPaymentHandler::didAuthorizePayment(WebCore::Payment const&) 4 0x10d78097c non-virtual thunk to WebCore::ApplePayPaymentHandler::didAuthorizePayment(WebCore::Payment const&) 5 0x10d77cabe WebCore::PaymentCoordinator::didAuthorizePayment(WebCore::Payment const&) 6 0x11e506dcf WebCore::MockPaymentCoordinator::acceptPayment()::$_6::operator()() 7 0x11e506c79 WTF::Function<void ()>::CallableWrapper<WebCore::MockPaymentCoordinator::acceptPayment()::$_6>::call() 8 0x11e4ce84b WTF::Function<void ()>::operator()() const 9 0x11e500ddc WebCore::dispatchIfShowing(WTF::Function<void ()>&&)::$_8::operator()() const 10 0x11e500cf9 WTF::Function<void ()>::CallableWrapper<WebCore::dispatchIfShowing(WTF::Function<void ()>&&)::$_8>::call() 11 0x108ca7e0b WTF::Function<void ()>::operator()() const 12 0x108cecc7d WTF::RunLoop::performWork() 13 0x108ced434 WTF::RunLoop::performWork(void*) 14 0x7fffb01df3e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 15 0x7fffb01c065c __CFRunLoopDoSources0 16 0x7fffb01bfb46 __CFRunLoopRun 17 0x7fffb01bf544 CFRunLoopRunSpecific 18 0x7fffaf71eebc RunCurrentEventLoopInMode 19 0x7fffaf71ecf1 ReceiveNextEventCommon 20 0x7fffaf71eb26 _BlockUntilNextEventMatchingListInModeWithFilter 21 0x7fffadcb5a54 _DPSNextEvent 22 0x7fffae4317ee -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 23 0x7fffadcaa3db -[NSApplication run] 24 0x7fffadc74e0e NSApplicationMain 25 0x7fffc5fe38c7 _xpc_objc_main 26 0x7fffc5fe22e4 xpc_main 27 0x10128a145 main 28 0x7fffc5d8a235 start 29 0x1 https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r227172%20(4862)/results.html
This test was just added with https://trac.webkit.org/changeset/227140/webkit
Created attachment 331752 [details] Patch
Created attachment 331754 [details] Patch
Comment on attachment 331754 [details] Patch Clearing flags on attachment: 331754 Committed r227260: <https://trac.webkit.org/changeset/227260>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36680569>
Still seeing the crash on Sierra bots: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r227289%20(4908)/results.html
Skipped test in https://trac.webkit.org/r227380 Andy, would you please take a look at this?
(In reply to Ryan Haddad from comment #8) > Skipped test in https://trac.webkit.org/r227380 > > Andy, would you please take a look at this? Should be fixed by https://trac.webkit.org/r227421
(In reply to Andy Estes from comment #9) > (In reply to Ryan Haddad from comment #8) > > Skipped test in https://trac.webkit.org/r227380 > > > > Andy, would you please take a look at this? > > Should be fixed by https://trac.webkit.org/r227421 Thanks, I'll have to re-enable the test.
(In reply to Ryan Haddad from comment #10) > Thanks, I'll have to re-enable the test. Done in r227423.