Bug 181826 - [Cocoa] Support font collections
Summary: [Cocoa] Support font collections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-18 18:45 PST by Myles C. Maxfield
Modified: 2018-05-30 03:43 PDT (History)
4 users (show)

See Also:


Attachments
Needs test (14.52 KB, patch)
2018-01-18 18:46 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (15.34 KB, patch)
2018-01-18 19:09 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (15.68 KB, patch)
2018-01-18 19:25 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (15.70 KB, patch)
2018-01-18 19:37 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-01-18 18:45:25 PST
[Cocoa] Support font collections
Comment 1 Myles C. Maxfield 2018-01-18 18:46:25 PST
Created attachment 331690 [details]
Needs test
Comment 2 Myles C. Maxfield 2018-01-18 18:46:58 PST
<rdar://problem/36455137>
Comment 3 EWS Watchlist 2018-01-18 18:47:39 PST
Attachment 331690 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Myles C. Maxfield 2018-01-18 19:09:56 PST
Created attachment 331692 [details]
Patch
Comment 5 Myles C. Maxfield 2018-01-18 19:19:41 PST
https://github.com/w3c/csswg-drafts/issues/2205
Comment 6 Myles C. Maxfield 2018-01-18 19:25:55 PST
Created attachment 331697 [details]
Patch
Comment 7 Myles C. Maxfield 2018-01-18 19:37:46 PST
Created attachment 331701 [details]
Patch
Comment 8 Dean Jackson 2018-01-19 14:41:51 PST
Comment on attachment 331701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331701&action=review

> Source/WebCore/ChangeLog:30
> +        No new tests because I don't have a font collection file with the appropriate license for the
> +        WebKit repository. I tested manually.

Can we create one?
Comment 9 Myles C. Maxfield 2018-01-22 18:03:30 PST
Comment on attachment 331701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331701&action=review

>> Source/WebCore/ChangeLog:30
>> +        WebKit repository. I tested manually.
> 
> Can we create one?

Yeah, I just haven't done it yet.
Comment 10 WebKit Commit Bot 2018-01-22 18:09:29 PST
Comment on attachment 331701 [details]
Patch

Clearing flags on attachment: 331701

Committed r227381: <https://trac.webkit.org/changeset/227381>
Comment 11 WebKit Commit Bot 2018-01-22 18:09:30 PST
All reviewed patches have been landed.  Closing bug.