Bug 181806 – AX: roles-computedRoleString.html layout test should support enabling/disabling individual test cases

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

The roles-computedRoleString.html layout test contains a large number of test cases, but no way to enable/disable an individual test case. Thus when there's a regression in just one specific element, gardeners wind up adding the test as a complete failure to TestExpectations and thus none of those tests get run on the affected platform. See, for example, bug 163383.

Given the importance of this particular layout test, and a lack of developer resources, we need a better solution. What is already being done for roles-exposed.html, namely adding a "data-platform" attribute to each element, would make it possible to enable/disable individual test cases for a given platform while allowing that platform to benefit from the remainder of the test.

[Radar WebKit Bug Importer]

<rdar://problem/36628710>

[Joanmarie Diggs]

Created attachment 331646 [details]
Patch

[Joanmarie Diggs]

Chris: Any objections?

[WebKit Commit Bot]

Comment on attachment 331646 [details]
Patch

Clearing flags on attachment: 331646

Committed r227158: <https://trac.webkit.org/changeset/227158>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Another approach would be to split the test into multiple files, and use the normal TestExpectations mechanism.