Bug 181803 - [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
Summary: [Xcode] Streamline and future-proof target-macOS-version-dependent build sett...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-18 10:51 PST by mitz
Modified: 2018-01-18 11:53 PST (History)
13 users (show)

See Also:

Attachments
First cut (81.44 KB, patch)
2018-01-18 10:52 PST, mitz 		no flags Details | Formatted Diff | Diff
Add and adopt macOSTargetConditionals.xcconfig (90.03 KB, patch)
2018-01-18 11:37 PST, mitz 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2018-01-18 10:51:28 PST 
Introduce a family of helper build settings that make it easier to define build settings whose value depends on the target macOS version without having to update those definitions in the future.
Comment 1 mitz 2018-01-18 10:52:09 PST 
Created attachment 331642 [details]
First cut
Comment 2 EWS Watchlist 2018-01-18 10:54:06 PST 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 mitz 2018-01-18 11:37:15 PST 
Created attachment 331645 [details]
Add and adopt macOSTargetConditionals.xcconfig
Comment 4 Alex Christensen 2018-01-18 11:49:44 PST 
Comment on attachment 331645 [details]
Add and adopt macOSTargetConditionals.xcconfig

Are we going to do something similar with iOS?
Comment 5 mitz 2018-01-18 11:50:42 PST 
Committed <https://trac.webkit.org/r227156>.
Comment 6 Radar WebKit Bug Importer 2018-01-18 11:51:40 PST 
<rdar://problem/36628533>
Comment 7 mitz 2018-01-18 11:51:54 PST 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 331645 [details]
> Add and adopt macOSTargetConditionals.xcconfig
> 
> Are we going to do something similar with iOS?

I don’t anticipate that we will, because we have never supported building for iOS with deployment target ≠ SDK version.
Comment 8 Radar WebKit Bug Importer 2018-01-18 11:53:00 PST 
<rdar://problem/36628581>