Bug 181796 – AX: Implement support for Graphics ARIA roles

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Joanmarie Diggs]

There is a graphics-aria spec [1] which introduces three roles:
* graphics-symbol
* graphics-document
* graphics-object

The platform mappings can be found in the graphics-aam spec [2].

Related: At the time we implemented the mappings for SVG defined in the svg-aam [3], I'm pretty sure the svg-aam itself had the platform details; now it says things like "Default Platform WAI-ARIA Role Mappings: graphics-symbol role ..." We might wish to make a similar adjustment in our support, and we should double-check nothing else has changed in the expected mappings.

[1] https://rawgit.com/w3c/graphics-aria/master/
[2] https://rawgit.com/w3c/graphics-aam/master/
[3] https://rawgit.com/w3c/svg-aam/master/

[Radar WebKit Bug Importer]

<rdar://problem/36617946>

[Joanmarie Diggs]

(In reply to Joanmarie Diggs (irc: joanie) from comment #0)
 
> Related: At the time we implemented the mappings for SVG defined in the
> svg-aam [3], I'm pretty sure the svg-aam itself had the platform details;
> now it says things like "Default Platform WAI-ARIA Role Mappings:
> graphics-symbol role ..." We might wish to make a similar adjustment in our
> support, and we should double-check nothing else has changed in the expected
> mappings.

We're blocked until we get some answers from the SVG AAM folks. So I opened bug 181856 for that work.

[Joanmarie Diggs]

Created attachment 331922 [details]
Patch

[chris fleizach]

Comment on attachment 331922 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=331922&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2310
> +        { "graphics-document", AccessibilityRole::Document },

You don’t think we need a separate role for this kind of document?

[Joanmarie Diggs]

Created attachment 331938 [details]
Patch

[Joanmarie Diggs]

(In reply to chris fleizach from comment #4)
> Comment on attachment 331922 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=331922&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2310
> > +        { "graphics-document", AccessibilityRole::Document },
> 
> You don’t think we need a separate role for this kind of document?

At the time I did the patch, no. But given your question, along with what was stated today in https://github.com/w3c/svg-aam/issues/1#issuecomment-359493725, it seems we may have a use case for a separate/dedicated role for graphics document as well as for graphics symbol. The patch in comment #5 does that.

[WebKit Commit Bot]

Comment on attachment 331938 [details]
Patch

Clearing flags on attachment: 331938

Committed r227344: <https://trac.webkit.org/changeset/227344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.