Bug 181794 - [css-align] The 'baseline' value must be invalid for the 'justify-content' property
Summary: [css-align] The 'baseline' value must be invalid for the 'justify-content' pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-18 04:32 PST by Javier Fernandez
Modified: 2018-01-30 08:05 PST (History)
8 users (show)

See Also:

Attachments
Patch (164.59 KB, patch)
2018-01-25 00:56 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Patch (167.93 KB, patch)
2018-01-29 06:18 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.19 MB, application/zip)
2018-01-29 07:19 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.54 MB, application/zip)
2018-01-29 07:24 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews114 for mac-sierra (2.93 MB, application/zip)
2018-01-29 07:43 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.15 MB, application/zip)
2018-01-29 07:48 PST, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews204 for win-future (11.55 MB, application/zip)
2018-01-29 10:27 PST, EWS Watchlist 		no flags Details
Patch (184.11 KB, patch)
2018-01-29 12:37 PST, Javier Fernandez 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-01-18 04:32:54 PST 
The CSS WG has resolved to drop the 'baseline' value from the 'justify-content' property's syntax.

https://github.com/w3c/csswg-drafts/issues/1184#issuecomment-295144365
Comment 1 Javier Fernandez 2018-01-25 00:56:27 PST 
Created attachment 332236 [details]
Patch
Comment 2 Javier Fernandez 2018-01-29 06:18:24 PST 
Created attachment 332536 [details]
Patch
Comment 3 EWS Watchlist 2018-01-29 07:19:08 PST 
Comment on attachment 332536 [details]
Patch

Attachment 332536 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6248880

New failing tests:
css3/parse-place-content.html
css3/parse-align-content.html
css3/parse-justify-content.html
Comment 4 EWS Watchlist 2018-01-29 07:19:09 PST 
Created attachment 332538 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-01-29 07:24:35 PST 
Comment on attachment 332536 [details]
Patch

Attachment 332536 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6248885

New failing tests:
css3/parse-place-content.html
css3/parse-align-content.html
css3/parse-justify-content.html
Comment 6 EWS Watchlist 2018-01-29 07:24:36 PST 
Created attachment 332539 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-01-29 07:43:02 PST 
Comment on attachment 332536 [details]
Patch

Attachment 332536 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6248906

New failing tests:
css3/parse-place-content.html
css3/parse-align-content.html
css3/parse-justify-content.html
Comment 8 EWS Watchlist 2018-01-29 07:43:03 PST 
Created attachment 332540 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-01-29 07:48:16 PST 
Comment on attachment 332536 [details]
Patch

Attachment 332536 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6248908

New failing tests:
css3/parse-place-content.html
css3/parse-align-content.html
css3/parse-justify-content.html
Comment 10 EWS Watchlist 2018-01-29 07:48:17 PST 
Created attachment 332541 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 11 EWS Watchlist 2018-01-29 10:27:29 PST 
Comment on attachment 332536 [details]
Patch

Attachment 332536 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/6250058

New failing tests:
css3/parse-place-content.html
css3/parse-align-content.html
css3/parse-justify-content.html
Comment 12 EWS Watchlist 2018-01-29 10:27:39 PST 
Created attachment 332552 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 13 Javier Fernandez 2018-01-29 12:37:27 PST 
Created attachment 332570 [details]
Patch
Comment 14 Antti Koivisto 2018-01-30 07:20:00 PST 
Comment on attachment 332570 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2018-01-30 08:03:20 PST 
Comment on attachment 332570 [details]
Patch

Clearing flags on attachment: 332570

Committed r227786: <https://trac.webkit.org/changeset/227786>
Comment 16 WebKit Commit Bot 2018-01-30 08:03:21 PST 
All reviewed patches have been landed.  Closing bug.
Comment 17 Radar WebKit Bug Importer 2018-01-30 08:05:42 PST 
<rdar://problem/37028881>